From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: v.pupillo@gmail.com, 55163@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode
Date: Thu, 28 Apr 2022 16:38:47 +0300 [thread overview]
Message-ID: <83fslxba54.fsf@gnu.org> (raw)
In-Reply-To: <87zgk5jtm6.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 28 Apr 2022 14:10:57 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 55163@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>, Eli Zaretskii
> <eliz@gnu.org>
> Date: Thu, 28 Apr 2022 14:10:57 +0200
>
> Vincenzo Pupillo <v.pupillo@gmail.com> writes:
>
> > the recent patch 4a1f69ebca broke the lsp-mode logging code. The logging code uses the expression
> > expression (/ (nth 2 (time-since before-send)) 1000) to
> > calculate the time of the event to be logged. lsp-mode starts the lsp-server, but is unable to work.
>
> Paul, it seems like this change is just breaking too much code out
> there, so I think it'll have to be reverted.
>
> Eli, what do you think?
I tend to agree.
I actually didn't expect Paul to make such changes, given the recent
discussion on emacs-devel, where he seemed to agree with my argument
against this kind of changes. But he did make this change regardless.
next prev parent reply other threads:[~2022-04-28 13:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 10:53 bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode Vincenzo Pupillo
2022-04-28 12:10 ` Lars Ingebrigtsen
2022-04-28 13:38 ` Eli Zaretskii [this message]
2022-04-28 20:15 ` Paul Eggert
2022-04-28 20:42 ` Vincenzo Pupillo
2022-04-28 21:55 ` Lars Ingebrigtsen
2022-04-28 21:51 ` Lars Ingebrigtsen
2022-04-29 9:54 ` Lars Ingebrigtsen
2022-04-29 10:54 ` Eli Zaretskii
2022-04-29 10:59 ` Lars Ingebrigtsen
2022-04-29 11:10 ` Eli Zaretskii
2022-04-29 19:38 ` Paul Eggert
2022-04-29 19:53 ` Eli Zaretskii
2022-04-29 22:45 ` Paul Eggert
2022-04-30 5:29 ` Eli Zaretskii
2022-04-30 9:10 ` Lars Ingebrigtsen
2022-04-30 10:00 ` Eli Zaretskii
2022-04-30 20:51 ` Paul Eggert
2022-05-01 5:38 ` Eli Zaretskii
2022-05-01 15:00 ` Paul Eggert
2022-05-01 15:42 ` Eli Zaretskii
2022-05-01 16:17 ` Paul Eggert
2022-05-01 16:43 ` Eli Zaretskii
2022-05-02 17:27 ` Paul Eggert
2022-05-02 17:58 ` Eli Zaretskii
2022-05-02 23:17 ` Paul Eggert
2022-05-03 2:32 ` Eli Zaretskii
2022-05-03 2:52 ` Paul Eggert
2022-04-30 1:44 ` Paul Eggert
2022-04-30 5:40 ` Eli Zaretskii
2022-04-30 11:21 ` Vincenzo Pupillo
2022-04-30 11:25 ` Eli Zaretskii
2022-04-30 12:32 ` Vincenzo Pupillo
2022-04-30 12:50 ` Eli Zaretskii
2022-04-30 13:22 ` Vincenzo Pupillo
2022-04-30 9:15 ` Lars Ingebrigtsen
2022-04-30 21:03 ` Paul Eggert
2022-05-01 5:40 ` Eli Zaretskii
2022-05-01 15:08 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fslxba54.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55163@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=larsi@gnus.org \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.