From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36649: 27.0.50; pure space and pdumper Date: Sat, 02 Jul 2022 20:11:23 +0300 Message-ID: <83fsjjbft0.fsf@gnu.org> References: <834k00es7e.fsf@gnu.org> <83zghsd7n6.fsf@gnu.org> <83a69rdgt9.fsf@gnu.org> <87a69r50yy.fsf@gnus.org> <838rpbdg3m.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22433"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 36649@debbugs.gnu.org, larsi@gnus.org, pipcet@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 02 19:12:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7gfC-0005dF-10 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 19:12:10 +0200 Original-Received: from localhost ([::1]:36574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7gfA-0005YQ-J1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 13:12:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7gf4-0005YI-4p for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 13:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7gf3-0005xc-SO for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 13:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7gf3-00077A-O4 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 13:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2022 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36649-submit@debbugs.gnu.org id=B36649.165678190227321 (code B ref 36649); Sat, 02 Jul 2022 17:12:01 +0000 Original-Received: (at 36649) by debbugs.gnu.org; 2 Jul 2022 17:11:42 +0000 Original-Received: from localhost ([127.0.0.1]:42789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7gek-00076a-DB for submit@debbugs.gnu.org; Sat, 02 Jul 2022 13:11:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7gei-00076O-V6 for 36649@debbugs.gnu.org; Sat, 02 Jul 2022 13:11:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7ged-0005vL-KO; Sat, 02 Jul 2022 13:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oCU4EF9MGmcwNG7kaTzvm41vqnMtdUawcIgnWArZMxQ=; b=NeN8rAnSv1IE d+9eHz77EgJoaI66WYJwcPeuRSOqJrYJ2SpTk5Nc+7KoTinRUsUXLVuoguEgKu2eglO3md2GTamg+ t3twpSTZBl+wWppm07uIvXq4YMBDRSkmPMGZVgHhDLc0ZID4i5I0RfQE6uAsDrrFssmag/Ru8xPAt BPO6s87dnXdyldplWzSpETlONQM2lQ/rbnCySIRkqTwhHCS3UvLYgu0H2KOPO6xhoBV7/jM2HLHpp 0wS2jPdnWyDKqquhYbXKb83KzK+flBssAdoA+RKq+pnZIvfzNx9v1NwDNwHoSeKatfoCoaKW37fYg rqpep5Kb4Hn7OL1EIHXg4A==; Original-Received: from [87.69.77.57] (port=1619 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7ged-0005yW-3l; Sat, 02 Jul 2022 13:11:35 -0400 In-Reply-To: (message from Stefan Monnier on Sat, 02 Jul 2022 12:57:09 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235941 Archived-At: > From: Stefan Monnier > Cc: Lars Ingebrigtsen , pipcet@gmail.com, > 36649@debbugs.gnu.org, luangruo@yahoo.com > Date: Sat, 02 Jul 2022 12:57:09 -0400 > > >> > Basically, I don't want us to drop the pure space in the unexec > >> > builds, whether it makes sense to the rest of you or not. > >> Could you explain why? > > Because I don't want to invest any significant effort in maintaining > > the unexec build. > > The patch does not touch the unexec code at all. It "touches" the unexec code in that it removes purespace, and thus changes the behavior of the unexec build. I don't want to deal with consequences of such a change. > If anything, it should make unexec simpler to maintain, since there's > one less issue to worry about (the current code might have to worry > about dumping the normal heap plus the purespace, whereas the new code > only has to worry about the normal heap), but `grep -i pur src/unex*.c` > suggests that the purespace has never had any impact on unexec. I'm not convinced, sorry. > > No, I'm okay with having the purespace removed from the pdumper > > builds, if the unexec build can still use it. AFAIU, that's the > > "behind several ifdefs" alternative. > > I don't know how to remove the purespace in pdump builds and not in > unexec builds. I don't even know what that would mean and/or look > like. Po Lu said it should be simple, so maybe he will propose a patch? > Would the patch below be acceptable? No, because it removes purespace unconditionally.