all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master 513c5d827d: Use `format-prompt' in
@ 2022-09-03  9:15 Eli Zaretskii
  2022-09-03  9:22 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 19+ messages in thread
From: Eli Zaretskii @ 2022-09-03  9:15 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

> branch: master
> commit 513c5d827decf474f923f6f66abd2ed62e0e64f0
> Author: Robert Pluim <rpluim@gmail.com>
> Commit: Robert Pluim <rpluim@gmail.com>
> 
>     Use `format-prompt' in `describe-char-fold-equivalences'
>     
>     * lisp/char-fold.el (describe-char-fold-equivalences): Use `format-prompt'.
> ---
>  lisp/char-fold.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lisp/char-fold.el b/lisp/char-fold.el
> index 2ac4cb0543..43e3cd45ec 100644
> --- a/lisp/char-fold.el
> +++ b/lisp/char-fold.el
> @@ -439,7 +439,9 @@ non-nil, means also include partially matching ligatures and
>  non-canonical equivalences."
>    (interactive (list (ignore-errors
>                         (read-char-by-name
> -                        "Unicode name, single char, or hex, default all: " t))
> +                        (format-prompt "Unicode name, single char, or hex"
> +                                       "all")
> +                        t))

Thanks, but is this supposed to be an improvement?  Before the change,
I knew what the text meant and what was the "all" part about; after
the change, I don't.  It's a net loss, since the code is now less
readable, and in fact without either running the code or looking at
what format-prompt does, one cannot understand what the prompt will
say in Real Life.

And don't get me started about the problems this should cause if and
when we'd like to translate our prompts.

IMO, format-prompt is useful where it makes the code more clear, but
blindly using it everywhere is not TRT in the long run.



^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2022-09-07 10:03 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-03  9:15 master 513c5d827d: Use `format-prompt' in Eli Zaretskii
2022-09-03  9:22 ` Lars Ingebrigtsen
2022-09-03  9:38   ` Eli Zaretskii
2022-09-03  9:45     ` Lars Ingebrigtsen
2022-09-03  9:56       ` Eli Zaretskii
2022-09-03 15:50       ` [External] : " Drew Adams
2022-09-05  4:04         ` Richard Stallman
2022-09-05  8:26           ` Robert Pluim
2022-09-05 11:42             ` Eli Zaretskii
2022-09-05 11:54               ` Robert Pluim
2022-09-05 12:19                 ` Eli Zaretskii
2022-09-05 12:29                   ` Robert Pluim
2022-09-05 12:33                     ` Eli Zaretskii
2022-09-05 16:02                       ` Gregory Heytings
2022-09-05 16:10                         ` Robert Pluim
2022-09-06  4:16               ` Richard Stallman
2022-09-06 12:37                 ` Eli Zaretskii
2022-09-07  2:23                   ` Richard Stallman
2022-09-07 10:03                     ` Robert Pluim

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.