From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 58288@debbugs.gnu.org, larsi@gnus.org, ajd2195@columbia.edu
Subject: bug#58288: 29.0.50; (flyspell-correct-word-before-point) followed by <down> crashes emacs
Date: Wed, 05 Oct 2022 13:06:52 +0300 [thread overview]
Message-ID: <83fsg2twhv.fsf@gnu.org> (raw)
In-Reply-To: <87k05e8u8w.fsf@gmail.com> (message from Robert Pluim on Wed, 05 Oct 2022 12:01:03 +0200)
> From: Robert Pluim <rpluim@gmail.com>
> Cc: 58288@debbugs.gnu.org, larsi@gnus.org, ajd2195@columbia.edu
> Date: Wed, 05 Oct 2022 12:01:03 +0200
>
> So the code is assuming that menu_items_used > 0 means that menu_items
> is valid, but we have this in menu.c:
>
> void
> save_menu_items (void)
> {
> Lisp_Object saved = list4 (menu_items_inuse ? menu_items : Qnil,
> make_fixnum (menu_items_used),
> make_fixnum (menu_items_n_panes),
> make_fixnum (menu_items_submenu_depth));
> record_unwind_protect (restore_menu_items, saved);
> menu_items_inuse = false;
> menu_items = Qnil;
> }
>
> This fixes it, but it seems a bit dodgy to me, why has no other
> platform ever run into this?
How come a menu is in use, but menu_items_inuse is zero?
next prev parent reply other threads:[~2022-10-05 10:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:20 bug#58288: 29.0.50; (flyspell-correct-word-before-point) followed by <down> crashes emacs Andrew John De Angelis
2022-10-04 11:19 ` Lars Ingebrigtsen
2022-10-04 12:32 ` Eli Zaretskii
2022-10-04 13:16 ` Robert Pluim
2022-10-04 13:47 ` Eli Zaretskii
2022-10-04 15:14 ` Robert Pluim
2022-10-04 16:30 ` Eli Zaretskii
2022-10-05 10:01 ` Robert Pluim
2022-10-05 10:06 ` Eli Zaretskii [this message]
2022-10-05 10:29 ` Robert Pluim
2022-10-05 10:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-05 13:53 ` Robert Pluim
2022-10-06 2:35 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fsg2twhv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58288@debbugs.gnu.org \
--cc=ajd2195@columbia.edu \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.