From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Tue, 08 Nov 2022 16:47:02 +0200 Message-ID: <83fsety049.fsf@gnu.org> References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58909@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 08 15:48:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osPtu-0009ZF-Vw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Nov 2022 15:48:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osPtY-0003eq-Hz; Tue, 08 Nov 2022 09:48:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osPtS-0003eX-TI for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 09:48:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osPtS-00073o-59 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 09:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osPtR-0002Pe-J0 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 09:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16679188489133 (code B ref 58909); Tue, 08 Nov 2022 14:48:01 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 14:47:28 +0000 Original-Received: from localhost ([127.0.0.1]:36750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osPst-0002NF-Pn for submit@debbugs.gnu.org; Tue, 08 Nov 2022 09:47:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osPss-0002N1-2A for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 09:47:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osPsm-0006yt-6X; Tue, 08 Nov 2022 09:47:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HJ+sHDCUHKkAAvzqxVd+TVnABcS67/YWAppmOiHyjDo=; b=MdfCEuBc3UBh JXzNLazs6E/YtuPkZW9R4plG/sHaXBVFFzWCbne4v0MhZaM/jnbAs9FsZDuLIVa0icnQQXTa4r2XY d7OM5PjUe5L+0JxA7nworWQycxgW+HCJps01MN8AZYZzUbhWqioqrCeSDK4/AYMHRcUrD6cf2dDa8 kGeplkxtrWsPtb3qczZI2WjX9MIrbrPWnJEUqKgGGZJJCBeelvdi3xx51rFS2akMVFTK2580qiYv6 QJykS209R3gTinYjO/Q7971nolEkN+DYuPcZ2c5dwnR4xolUT9ZyF73M7AHdNwBR8lZDcYmgV+q1y XTg7rQ9CzxJYdriwcS7MZg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osPsh-0004bt-OR; Tue, 08 Nov 2022 09:47:18 -0500 In-Reply-To: (message from Jim Porter on Sun, 6 Nov 2022 12:23:58 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247335 Archived-At: > Date: Sun, 6 Nov 2022 12:23:58 -0800 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > I also attached a second patch to show an idea I had: since the first > patch adds a minor-mode keymap for 'server-mode' (and ensures that the > mode is activated whenever the server is running), we could get rid of > the server-specific logic from lisp/files.el. Instead of mapping 'C-x > C-c' to 'save-buffers-kill-terminal' all the time, Emacs could map it to > 'save-buffers-kill-emacs' by default. Then, when the server is running, > remap 'save-buffers-kill-emacs' to 'save-buffers-kill-terminal'. This means a different binding for "C-x C-c" depending on situation, and the binding to save-buffers-kill-terminal depending on a minor mode. Previously, "C-x C-c" would do its job regardless of the mode. I'm not sure this is for the best. I'd be interested to hear from others, if anyone has an opinion.