From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59730: gdb-mi.el: Local variables reordering Date: Sat, 03 Dec 2022 21:58:41 +0200 Message-ID: <83fsdwcl8u.fsf@gnu.org> References: <83y1rrgmc3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59730@debbugs.gnu.org To: Gustaf Waldemarson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 03 21:00:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1YgT-0008Ld-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Dec 2022 21:00:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Yg9-0002Er-LV; Sat, 03 Dec 2022 15:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Yg7-0002Ds-EZ for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 15:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1Yg7-0004YP-5Q for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 15:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1Yg6-0000e1-KD for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 15:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Dec 2022 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59730 X-GNU-PR-Package: emacs Original-Received: via spool by 59730-submit@debbugs.gnu.org id=B59730.16700975522436 (code B ref 59730); Sat, 03 Dec 2022 20:00:02 +0000 Original-Received: (at 59730) by debbugs.gnu.org; 3 Dec 2022 19:59:12 +0000 Original-Received: from localhost ([127.0.0.1]:53039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1YfH-0000dE-G7 for submit@debbugs.gnu.org; Sat, 03 Dec 2022 14:59:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1YfF-0000d5-RZ for 59730@debbugs.gnu.org; Sat, 03 Dec 2022 14:59:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1YfA-0004S7-DO; Sat, 03 Dec 2022 14:59:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FiLZImLL4yugVu0BdZOww6df4hZVxcyw6K4MX6I+jgI=; b=e1/IKNOyEBrF jMyOrosxogNnj0/juevZrzUqidSDKaxW/a5ho77ec9kD7KZxE3Ki71OQOCKpqaahkdVCx6keVa8VH WE/nX7yATcSMuw14AactLiVvyEzqDEEFVyQBm3gDhy5g8Nkk9UziKAFLga7l5N0Z/ikkxFlkm1Luh Oj9i3pletnkE/LzM+d96cC2P3FnFvl6n4QFCHCZOIz82DwZaMS3RI/avPUnt1UKyMuz6/4FDL0u/M 57QQFLs/IF1WNvrXCeK4/Yl/yR5v8B15X5zygzIdnmW8b5KQVRxNE3RXPFPOKwgnUnbJ3XDSnhXRv wMU0iVuQgnT64mWf3dnnFQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Yf9-0002ez-AD; Sat, 03 Dec 2022 14:59:04 -0500 In-Reply-To: (message from Gustaf Waldemarson on Thu, 1 Dec 2022 22:53:26 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249872 Archived-At: > From: Gustaf Waldemarson > Date: Thu, 1 Dec 2022 22:53:26 +0100 > Cc: 59730@debbugs.gnu.org > > The updated patch is attached to this mail. Thanks. I have a couple of minor comments: > +(defcustom gdb-locals-max-type-length 20 > + "Maximum number of character to display in the local variables type column." > + :type 'integer > + :group 'gud > + :version "30.0") This should be "30.1". We don't release NN.o versions of Emacs. > +(defcustom gdb-locals-max-name-length 20 > + "Maximum number of character to display in the local variables name column." > + :type 'integer > + :group 'gud > + :version "30.0") Likewise. Also, please add more detailed description of what these options control. The first line of the doc string is fine, but please add more text explaining that this setting is for displaying the variables in the "Locals" buffer. > - (propertize type 'font-lock-face font-lock-type-face) > - (propertize name 'font-lock-face font-lock-variable-name-face) > + (propertize (string-truncate-left name gdb-locals-max-name-length) > + 'font-lock-face font-lock-variable-name-face > + 'help-echo name) > + (propertize (string-truncate-left type gdb-locals-max-type-length) > + 'font-lock-face font-lock-type-face > + 'help-echo type) I'm uncomfortable with backward-incompatible change in behavior for which there's no way of getting the old behavior. So please add another defcustom that could be used to get the original order of type/name/value. There also should be a NEWS entry about these new options, and the text there should explain how to get back old behavior before these changes.