From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH for 29.1] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Sun, 04 Dec 2022 19:56:46 +0200 Message-ID: <83fsdv9hnl.fsf@gnu.org> References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> <79a53ecc-dbfc-d088-d80d-96f349be794a@gmail.com> <834k7vw2vb.fsf@gnu.org> <87czc4tosz.fsf@gnus.org> <83lepoi58p.fsf@gnu.org> <83y1tbxbbt.fsf@gnu.org> <83h6zxwujo.fsf@gnu.org> <2738f071-c87f-72cf-226f-6e8597cb07a8@gmail.com> <83a65ouz0e.fsf@gnu.org> <83lenrghhg.fsf@gnu.org> <8e62e7aa-7050-6b35-9128-79517efa4557@gmail.com> <83edthgam5.fsf@gnu.org> <9b079bad-8d51-02b9-baad-151c57cfed3f@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28090"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 04 18:58:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1tFr-000785-J1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Dec 2022 18:58:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1tFb-000630-FC; Sun, 04 Dec 2022 12:58:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1tFa-00062k-TJ for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 12:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1tFa-0006NE-LM for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 12:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1tFa-00077z-GQ for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 12:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2022 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.167017663127387 (code B ref 51993); Sun, 04 Dec 2022 17:58:02 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 4 Dec 2022 17:57:11 +0000 Original-Received: from localhost ([127.0.0.1]:58955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1tEk-00077f-TQ for submit@debbugs.gnu.org; Sun, 04 Dec 2022 12:57:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1tEj-00077Z-UE for 51993@debbugs.gnu.org; Sun, 04 Dec 2022 12:57:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1tEe-0006HL-IA; Sun, 04 Dec 2022 12:57:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=s98NJkb+7iq1YUeYpfILoQiawAe6lvP83g1/fqmrDV8=; b=IHhnoFjvG+8R 2Jf0ciuMeeJf44lHfMFx2aT2xqmdPD/gNTHhzMnJ/75f0TjdpRGEG+tt/kUqPa/Bsgs3Klb+WFW9F xIi6g9rZQ3bxNWIDkaPMxnSlB27IueQzi78x9SckkIcd6ufGQ9croCamjhzksNX6DOcc8loDGhbf/ vOX6XG8pvv4JJ7W8oZtDVOahuKJUW7CWBjOxxuEPJ8IcWT8jG6sCHXOS6KgFeoHXZYJ8WsPJcyeC5 p168KEowdAh71Of8PXlevqz6PcQLM3CmL9n7pyzj9WErgewxjk5DRWtd3pG3KSqomm355c2LPFLA/ 2obkFF3FL5GpzfADV+BWlA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1tEd-0007kH-UA; Sun, 04 Dec 2022 12:57:04 -0500 In-Reply-To: <9b079bad-8d51-02b9-baad-151c57cfed3f@gmail.com> (message from Jim Porter on Fri, 2 Dec 2022 13:33:39 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249959 Archived-At: > Date: Fri, 2 Dec 2022 13:33:39 -0800 > Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org > From: Jim Porter > > > And here you completely rewrote a function. > > Thinking about this some more, that change wasn't strictly necessary for > 29.1, since it should really just be dead code, and won't hurt anything. > I've split this part out into a separate commit that we could apply to > only the master branch. That simplifies the first commit (for 29.1) a > fair bit. Thanks, I'm okay with committing these two patches, each one to its branch. (But I guess you need to wait with installing the second one until the first one is merged to master, right?)