From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60333: [PATCH] whitespace: Update bob, eob markers in base and indirect buffers Date: Thu, 12 Jan 2023 11:33:15 +0200 Message-ID: <83fscgksh0.fsf@gnu.org> References: <87k02dz75f.fsf@localhost> <87358zprk1.fsf@localhost> <45afa067-f63d-e013-a547-ea4ef0c27935@rhansen.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13921"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60333@debbugs.gnu.org, yantar92@posteo.net To: Richard Hansen , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 12 10:33:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFtxT-0003T9-Ft for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Jan 2023 10:33:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFtxL-0003nZ-Mi; Thu, 12 Jan 2023 04:33:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtxG-0003mW-Om for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFtxG-0007RK-Ek for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFtxG-0006zM-5a for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2023 09:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60333-submit@debbugs.gnu.org id=B60333.167351597226848 (code B ref 60333); Thu, 12 Jan 2023 09:33:02 +0000 Original-Received: (at 60333) by debbugs.gnu.org; 12 Jan 2023 09:32:52 +0000 Original-Received: from localhost ([127.0.0.1]:44686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtx5-0006yy-HH for submit@debbugs.gnu.org; Thu, 12 Jan 2023 04:32:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtx4-0006yl-30 for 60333@debbugs.gnu.org; Thu, 12 Jan 2023 04:32:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtwy-0007MC-ET; Thu, 12 Jan 2023 04:32:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SJ0iICChQEv1m0Afo1EwIOYmbRbMJlU6l0SCF9HKk8A=; b=pgcLCs5AsEw+ 5FzS3uctkMmKexzh67qXia8rQA9vRPtsWmURnIPcgchHG4GR0Dt3oxwpo483WARYn879LfdM8b/8d 7CUkLhV4VgpNBYhcXyoAQIqe52NehEHjIm5O1y4tV2uaI7D4VuVZH+6WFcUstr1sdbIGrvxk7jtzx 3KKZLT/DYzuv2btUm7N44pXuTnMvo+mgvvuUcwuiOhLbneTImwMH8Aysm8N75CjK4eQih8ulKn7Dq YyXpTBYaC259qAO1G6zDwNN8eSz5syYgouW1hcUonNVl0iCKmnchvn01+oByb8eIBcmQM7FAhQJVP EPwHJeIeS+9c4xXrLGL5CA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtwv-0000Xy-Ju; Thu, 12 Jan 2023 04:32:44 -0500 In-Reply-To: <45afa067-f63d-e013-a547-ea4ef0c27935@rhansen.org> (message from Richard Hansen on Thu, 29 Dec 2022 03:11:11 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253195 Archived-At: > Cc: 60333@debbugs.gnu.org > Date: Thu, 29 Dec 2022 03:11:11 -0500 > From: Richard Hansen > > On 12/28/22 09:44, Stefan Monnier wrote: > >>> "Expose" is the wrong term, because we don't have that info ready to > >>> be exposed. We'd either have to create&maintain that list, or compute > >>> it on-demand when requested. > > [...] > >> 1. Maintain internal indirect buffer list associated with buffers in C > > > > That's the "create&maintain that list" option. > > Personally I don't like it: I'd like to reduce the amount of support we > > provide in C for indirect buffers rather than increase it. > > What alternative would you prefer? > > How about something like this in a shared location (e.g., simple.el next > to `clone-indirect-buffer'): > > (defvar indirect-buffers--cached nil) > > (defun indirect-buffers--invalidate-cache () > (setq indirect-buffers--cached nil) > (remove-hook 'buffer-list-update-hook > #'indirect-buffers--invalidate-cache)) > > (defun indirect-buffers () > (unless indirect-buffers--cached > (setq indirect-buffers--cached '(nil nil)) > (dolist (buf (buffer-list)) > (let ((base (buffer-base-buffer buf))) > (when base > (push buf (plist-get indirect-buffers--cached base))))) > (add-hook 'buffer-list-update-hook > #'indirect-buffers--invalidate-cache)) > indirect-buffers--cached) > > Other options I can see: > > #1: Apply this patch as-is, keep Org as-is, and live with the code > duplication. > #2: Reject this patch and keep Org as-is. > #3: Advise `make-indirect-buffer'. The advice would record new > indirect buffers and add a `kill-buffer-hook' function to clean up the > entry. (Note, however, that `make-indirect-buffer' is a primitive > function.) > #4: Fix Bug#46982. (One possible approach that maintains backwards > compatibility: Teach `after-change-functions' to look for a symbol > property that means "run me not just for changes made in this buffer, > but also if a change is made in this buffer's base/indirect buffer".) And this.