From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Mon, 13 Feb 2023 15:19:11 +0200 Message-ID: <83fsb9g0ts.fsf@gnu.org> References: <837cx8cey0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17065"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, rlb@defaultvalue.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 13 14:20:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRYko-0004BX-Jk for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Feb 2023 14:20:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRYk8-0002Yk-Dj; Mon, 13 Feb 2023 08:19:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRYk6-0002YH-Nr for emacs-devel@gnu.org; Mon, 13 Feb 2023 08:19:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRYk4-0005ND-UM; Mon, 13 Feb 2023 08:19:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=f3HaZGOM4+0eoVR+uUI/VN7DQrgsucYdjdFK+gKpJzw=; b=pfdPup20ZoAq jNlYbPqr+T9aVIw5BDJ1IU0M7sHenygmxjFWCi++rIc56OtHEL+cJtMPdJ2//qNe0iSXY/BF+2dcP OvTsX3sLYkv0UT66fBuwVAkNbF202voIq6TlWW3wbI41jqMdU/vJkgDqxJi7+EVcfoOlfRvNwqtqe T77Ca5lkeaYj0lEAsmWrMjNi7hqzkjeEUsAg7q7b6ApgDhu0wZHkILFq9HGRxHlVNHIzSXX5+9Wvh LPmw2hu1zj+X52IBHOU/sNEM0r/yXsYpM8ZVNNFpixowoDOPrU08gWGyEfMW29frmMdZzwO6Uelzg ge57SKGUxHMtxWjPTKXbgw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRYk4-0006yO-7a; Mon, 13 Feb 2023 08:19:36 -0500 In-Reply-To: (message from Andrea Corallo on Mon, 13 Feb 2023 12:05:09 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303212 Archived-At: > From: Andrea Corallo > Cc: emacs-devel@gnu.org, Lars Ingebrigtsen , Stefan > Monnier , Rob Browning > Date: Mon, 13 Feb 2023 12:05:09 +0000 > > Hello all, > > at feature/inhibit-native-comp-cleanup I've pushed the branch I'm > testing that: > > . removes the EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION environment > variable > . removes `inhibit-automatic-native-compilation' variable and uses > `native-comp-deferred-compilation', with or without > `comp-enable-subr-trampolines' (as needed), instead > . adds a third possible value to `comp-enable-subr-trampolines', a > string that specifies a directory in which to deposit the JIT > compiled trampolines > . updates the doc string of `native-comp-never-optimize-functions' to > mention its effect on trampolines > . updates some do doc here and there accordingly Thanks, I will take a look shortly. > - I think renaming `native-comp-deferred-compilation' to > `native-comp-jit-compilation' might be more descriptive to the user > but I guess we are late now? :/ > > - If `comp-enable-subr-trampolines' is meant to be used by the user we > should probably rename it into `native-comp-enable-subr-trampolines'? > I guess we are late as well? We can add new names, and make the old ones obsolete aliases. Then we could remove the obsolete aliases in some future release. > - I left the piece of code that, when removing an eln file on windows, > guards for errors. This to be extra cautious, I'm not aware of any > exection path were we should remove an eln while loaded now, but maybe > we could remove that piece of code only on the emacs-30 branch. Agreed. > Last question for my knowledge: what's the exact reason why we want a > third possible value for `comp-enable-subr-trampolines' and we can use > `native-comp-eln-load-path' to redirect the trampoline compilation? Is > this to support packagers wanting to produce eln files only for packages > but not for trampolines? That's one treason, AFAIR. Another is that a single scalar variable is easier to modify without screwing up than a list of directories, especially since one of those directories must be the last one...