From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit Date: Sat, 25 Mar 2023 15:55:02 +0300 Message-ID: <83fs9tc7o9.fsf@gnu.org> References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> <87wn365e3t.fsf@posteo.net> <87pm8yaq24.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35093"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, joaotavora@gmail.com, 62417@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 13:56:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg3Rj-0008tK-P8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 13:56:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg3RD-0006UA-CO; Sat, 25 Mar 2023 08:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg3RC-0006Tx-PG for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg3RC-0004vo-C8 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg3RC-0005oo-3m for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167974892922315 (code B ref 62417); Sat, 25 Mar 2023 12:56:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 25 Mar 2023 12:55:29 +0000 Original-Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg3QZ-0005nj-5C for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:55:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg3QQ-0005nF-4n for 62417@debbugs.gnu.org; Sat, 25 Mar 2023 08:55:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg3QI-00045x-FU; Sat, 25 Mar 2023 08:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cf28bOe0DHamsvZF5tsypvor2OvhAbuaUwycSx/QRSc=; b=CPn3K+NfMaoPUkTAFh7i Okq8oEp3FAHsrX15t+IEwITL1rFYRML+CK2uY7eaHcZ0vozMXKl5QHDiZ6WaZVFLRgZiEPlOEkTLz YPanPL4r/TBjTnHl0OG7OgaJtzmz37jxZAWrO9ukJieFqI1gvjHqlH2SJhOnOmWgvySC2/RW9pdL6 /XgZDNw/TbE7KUp+UzXDyc+bUV87CMFNl2p2uHAj1Xuh9fCpx7Ogw3E9KXnASbenWUf3lLuBZ+JMQ 03AnWvqwEoJ1w7dVOfVfBt7mScyoECup31KGcSJKg/PIS5kqcv1N6zIe9hgtTXphs5sIx/EJi/XY1 zcifl2EifnEPvA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg3QH-0002eA-0p; Sat, 25 Mar 2023 08:55:05 -0400 In-Reply-To: <87pm8yaq24.fsf_-_@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Fri, 24 Mar 2023 19:48:35 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258559 Archived-At: > Cc: 62417@debbugs.gnu.org > From: João Távora > Date: Fri, 24 Mar 2023 19:48:35 +0000 > > If the previous explanation is somehow hard to understand, here's a > hopefully simpler one with a repro which doesn't require SLY. In Emacs > 28 the docstring for `display-buffer-alist` states (emphasis mine): > > If non-nil, this is an alist of elements (CONDITION . ACTION), > where: > > CONDITION is either a regexp matching buffer names, or a > function that takes two arguments - a buffer name and the > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > ACTION argument of `display-buffer' - and returns a boolean. > > In Emacs 29, the docstring was changed to state: > > If non-nil, this is an alist of elements (CONDITION . ACTION), > where: > > CONDITION is passed to `buffer-match-p', along with the buffer > that is to be displayed and the ACTION argument of > `display-buffer', to check if ACTION should be used. > > Any code that was written for the Emacs 28 contract in mind like, for > example: > > (defun foop (buffer-name _alist) (string-match "foop" buffer-name)) > > (add-to-list 'display-buffer-alist '(foop . display-buffer-other-frame)) > > Will now fail with an obscure error message. I've checked "Incompatible > Lisp Changes in Emacs 29.1" in etc/NEWS and could not find a mention to > this, so I assume it was not intentional. > > So it is most clearly a regression. There's something missing in the above description, since buffer-match-p accepts a function as its CONDITION argument, and calls that function with the buffer and ACTION. So it sounds like code written for Emacs 28 should still work. What is missing here that explains the breakage?