From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE Date: Sat, 22 Apr 2023 10:17:51 +0300 Message-ID: <83fs8s2xnk.fsf@gnu.org> References: <82E7ADEC-25BC-475B-8EE0-839FE78FF2F4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62951@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 22 09:18:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pq7Vr-0004rG-0Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Apr 2023 09:18:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pq7VT-0001bT-Sj; Sat, 22 Apr 2023 03:18:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq7VS-0001bI-Q2 for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 03:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pq7VS-0006oU-HY for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 03:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pq7VS-0005oO-A1 for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2023 03:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62951 X-GNU-PR-Package: emacs Original-Received: via spool by 62951-submit@debbugs.gnu.org id=B62951.168214786422313 (code B ref 62951); Sat, 22 Apr 2023 07:18:02 +0000 Original-Received: (at 62951) by debbugs.gnu.org; 22 Apr 2023 07:17:44 +0000 Original-Received: from localhost ([127.0.0.1]:41585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pq7V9-0005np-Vr for submit@debbugs.gnu.org; Sat, 22 Apr 2023 03:17:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pq7V7-0005nR-G9 for 62951@debbugs.gnu.org; Sat, 22 Apr 2023 03:17:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq7V2-0006iM-4K; Sat, 22 Apr 2023 03:17:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8h2R99nYiL1NiDU1K82mENOASocpawu/VfQ0ziX/A6c=; b=N1hJQc24anejM9AqG/Yw +cSLg5lE85gGOHgndo3w5xANU3vGu0oXIlm+rNMZDZdqj+Ok7VY2X1y1N+Pzo8K9uOW0ELq85BTmw LdwU9R/YwkgvdmSr7djBIT9ygya0Yl9mt63cLhJ09ZIILSh/85f0Xy3WbCHLn6e9uBbOcgKI5Q0fw 2NnqkKFjTc2Sjqz9jnwGkZHpX90+PNzCxMEApINnAeYUcpLAdisJizu15+JO1DAki+8vJ7IjOiB6z NP7u3lMGSWEqNfpr/LHCzoBlbAMWlriH1uj+yYiKqDnwrSojlEZn+555/Zy0cX/q8TNHA4ih9mbED y7wSRuoQniAWrg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq7V0-0002Mv-EG; Sat, 22 Apr 2023 03:17:34 -0400 In-Reply-To: <82E7ADEC-25BC-475B-8EE0-839FE78FF2F4@gmail.com> (message from Yuan Fu on Fri, 21 Apr 2023 13:37:08 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260430 Archived-At: > From: Yuan Fu > Date: Fri, 21 Apr 2023 13:37:08 -0700 > Cc: 62951@debbugs.gnu.org > > > Eli Zaretskii writes: > > > To reproduce: > > > > emacs -Q > > C-x C-f src/fns.c RET > > C-u 3365 M-g g > > > > Observe that "if" and "STRINGP" in the body of FOR_EACH_TAIL_SAFE are > > fontified in font-lock-function-name-face. This is because the > > FOR_EACH_TAIL_SAFE macro is misparsed by tree-sitter as a declaration. > > > > Can we teach c-ts-mode to recognize FOR_EACH_TAIL_SAFE and > > FOR_EACH_TAIL for what they are, perhaps conditioned on > > c-ts-mode-emacs-sources-support being non-nil? > > I’m aware of this issue, but the truth is there isn’t a good solution to > it. We need to recognize FOR_EACH_TAIL_SAFE (not hard) and fix arbitrary > code after it (hard). In this case it’s a if statement, with macro calls > and AND operation in it’s condition, it’s already three things we need > to recognize and somehow handle. It can also be a for loop, a switch > case, a function call, a while loop. If we want to fix FOR_EACH_TAIL we > would need to handle every possible thing, at that point we might as > well have wrote a parser :-) Sorry, I don't understand the difficulties. The body of FOR_EACH_TAIL and a few similar macros we use could be on of the following: . a single simple statement . an 'if' clause . a 'while' loop . a 'do' loop . a 'for' loop . a brace-delimited block (this one already works, AFAICS, so we perhaps need not anything about it) (In practice, only the first 2 and the last one are used, AFAICS.) Doesn't tree-sitter tell us enough to figure out which of the above is in the body? If so, why would we need to write a full parser? > We can probably fix this very particular case, but it’s still work and > overhead, and doesn’t mean much. Please understand: good support for editing Emacs C sources is from my POV imperative for c-ts-mode to gain traction. One of my gripes about CC Mode was insufficient support for our macro system and for various GCC attributes; that improved recently to some extend, but not enough, and at a price of introducing ugly lists of strings that cause trouble when used in file-local variables. We must do better in c-ts-mode! So please make an effort of providing reasonable built-in solutions for these idiosyncrasies of the Emacs C sources, conditioned on the new variable c-ts-mode-emacs-sources-support, at least for those of them that are used widely enough. It is very important. TIA