From: Eli Zaretskii <eliz@gnu.org>
To: Eshel Yaron <me@eshelyaron.com>
Cc: 62864@debbugs.gnu.org
Subject: bug#62864: 30.0.50; Interactive forms that fail to provide required arguments
Date: Sat, 06 May 2023 11:32:12 +0300 [thread overview]
Message-ID: <83fs89hncj.fsf@gnu.org> (raw)
In-Reply-To: <m18retyuh9.fsf@eshelyaron.com> (bug-gnu-emacs@gnu.org)
> Date: Sat, 15 Apr 2023 19:34:58 +0300
> From: Eshel Yaron via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I've noticed that dictionary.el defines some functions with an
> `interactive' form that doesn't provide their required arguments.
>
> For example, `dictionary-new-search' must be called with at least one
> argument, but when called interactively it gets called with no
> arguments. The other two such cases in dictionary.el are
> `dictionary-definition' and `dictionary-switch-tooltip-mode'.
>
> IIUC, these "commands" are never actually called interactively, and it
> should be safe to simply drop the `interactive' form so they don't show
> up in `M-x dictionary- TAB'.
>
> A quick scan of the lisp/ directory of emacs.git reveals a similar issue
> with the following function definitions:
Thanks, I've now fixed many of those on the master branch. Notable
exceptions are Org files and those in the lisp/obsolete subdirectory.
prev parent reply other threads:[~2023-05-06 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 16:34 bug#62864: 30.0.50; Interactive forms that fail to provide required arguments Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 8:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fs89hncj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62864@debbugs.gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.