From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63470: [PATCH] Use faster option for running vc-hg status Date: Sat, 13 May 2023 08:51:24 +0300 Message-ID: <83fs80bwyr.fsf@gnu.org> References: <83h6shbaiv.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26519"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63470@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 13 07:52:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxiB7-0006je-OM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 May 2023 07:52:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxiAn-0006mT-4u; Sat, 13 May 2023 01:52:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxiAk-0006mH-PG for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 01:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxiAk-0002uS-FS for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 01:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxiAk-0000AH-CE for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 01:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2023 05:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63470-submit@debbugs.gnu.org id=B63470.1683957097599 (code B ref 63470); Sat, 13 May 2023 05:52:02 +0000 Original-Received: (at 63470) by debbugs.gnu.org; 13 May 2023 05:51:37 +0000 Original-Received: from localhost ([127.0.0.1]:35409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxiAK-00009b-FI for submit@debbugs.gnu.org; Sat, 13 May 2023 01:51:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxiAG-00009J-8u for 63470@debbugs.gnu.org; Sat, 13 May 2023 01:51:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxiAA-0002ma-Nd; Sat, 13 May 2023 01:51:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Jq0t0C14yVvCzwhWWmHZLC2A0QuS7Z3HiXFAB2HSTwU=; b=itKasRhqRHnt 5SgN018g09DVK4hQA9xXtIlLqM8Aqbhf1qyz6vJziXrP+JtBl0sReRMlzOSr1WpH12eO69M0B8PB2 JJIiwxFR+I4OvHzKhL7Npkp2tSSskZrz9PIamVqzJXdVbc37rxDxicQmE8u3wjqLKLNGd74y7oZXm aCP14DR4SqPu8T1UZoThTzTjzA5FZF2JZzuCUz59UKtQkh0DzeG91jvKO8naqcmD8ZNhedYgvot7J 4Ydp3TECTAnQYQg76F9mzPD0xkqgLuNI8KEjS3RNiOty/RNrJAXjyP9CYtARmZwtk6rafhsRy/cbu DaBhUhJlpxpz20Mr/tMZ7g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxiAA-0008PT-As; Sat, 13 May 2023 01:51:26 -0400 In-Reply-To: (message from Spencer Baugh on Fri, 12 May 2023 15:57:41 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261659 Archived-At: > From: Spencer Baugh > Cc: 63470@debbugs.gnu.org > Date: Fri, 12 May 2023 15:57:41 -0400 > > Eli Zaretskii writes: > > I don't understand: what will happen to users of Mercurial < 4.2? > > They will get an error message and the vc-dir buffer will fail to > update. That's unacceptable, sorry. There are better solutions than just stop supporting those users, so this is too harsh. > > And why cannot we detect the version and dispatch on that, instead of > > doing this unconditionally? > > hg --version takes a quarter of a second on my machine, which itself > wipes out a lot of the performance benefit. We could cache it, but it's > not clear to me how to do that correctly: there could be different hg > binaries in different directories, or over TRAMP, or other such things. There's no reason to assume there's more than one Mercurial installation on PATH. We could allow reinitialization of the version, but that would be holier that Pope, IMO. We don't do that with Git, AFAIR. > I could add a user option to revert to the old behavior, if you want. The result of the version test could set the value of the defacustom, but if we add such a defcustom, its default value should be to probe the system, not to assume version 4.2 or later. > (It would be nice if vc was available on ELPA, then maybe we could just > tell users of old mercurial versions to downgrade to an old version...) Does package.el support downgrading of packages, let alone of built-in packages?