From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64089: 30.0.50; `ldap-search' errors out with `wrong-type-argument listp' when called WITHDN == t Date: Tue, 20 Jun 2023 14:01:26 +0300 Message-ID: <83fs6m75yx.fsf@gnu.org> References: <83cz1usk0i.fsf@gnu.org> <83legiqy3x.fsf@gnu.org> <83h6r6qwxh.fsf@gnu.org> <83mt0xpcns.fsf@gnu.org> <83r0q774b9.fsf@gnu.org> <83ilbj6zhs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18702"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jschmidt4gnu@vodafonemail.de, 64089@debbugs.gnu.org, monnier@iro.umontreal.ca To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 20 13:02:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBZ8Q-0004UM-K3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jun 2023 13:02:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBZ8D-00047a-15; Tue, 20 Jun 2023 07:02:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZ7d-00040O-FD for bug-gnu-emacs@gnu.org; Tue, 20 Jun 2023 07:02:19 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBZ7a-0001fy-CE for bug-gnu-emacs@gnu.org; Tue, 20 Jun 2023 07:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBZ7a-0001xT-6n for bug-gnu-emacs@gnu.org; Tue, 20 Jun 2023 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64089 X-GNU-PR-Package: emacs Original-Received: via spool by 64089-submit@debbugs.gnu.org id=B64089.16872588947482 (code B ref 64089); Tue, 20 Jun 2023 11:02:02 +0000 Original-Received: (at 64089) by debbugs.gnu.org; 20 Jun 2023 11:01:34 +0000 Original-Received: from localhost ([127.0.0.1]:58170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZ78-0001wc-8D for submit@debbugs.gnu.org; Tue, 20 Jun 2023 07:01:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZ76-0001wP-0s for 64089@debbugs.gnu.org; Tue, 20 Jun 2023 07:01:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZ70-0001Wr-15; Tue, 20 Jun 2023 07:01:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rUSiScNgPpP2xfmnPNylYfJDZVJjr1Ap+5WzjQblb2c=; b=aQWS9wMkY96P nnlZERXmDCGBuhvGhNJKVWLKNZWKLrD8963ntD7fxlX1/iYQ3Ldn7CNgnQVruwqTPcQ3+GKgKI7Se M1kZVBaRb3q+TIF/1wN21t7JT+GIL7pmbe3gHfIyrVboXmB6+ibjRuMecEsy0dsZMK7KUbj6f2Vw8 +ApCZvbUZ08yaG0vSMs02z0mtcYCPF4zSwh3out2VXBR1KNV5f+o3d97FFnzlAROzYVqs9sUCVTVa L/FC5+F6kZNSuJaTiYaNtVmCEc2kd+i6gy9i432X8eAoKZAKSi9COMV/8NdAYgJJx3SbWanZNiDiR 4EocgXfgo7zv2AQ/UaWdwg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZ6v-0002Kk-6J; Tue, 20 Jun 2023 07:01:25 -0400 In-Reply-To: (message from Filipp Gunbin on Mon, 19 Jun 2023 22:27:01 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263748 Archived-At: > From: Filipp Gunbin > Cc: 64089@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de, > monnier@iro.umontreal.ca > Date: Mon, 19 Jun 2023 22:27:01 +0300 > > >> The above formats are what ldap-search returns when given withdn=t. > >> > >> Emacs codebase doesn't use withdn=t at all, but ldap-search is a "public" > >> API function, and we're not supposed to change its return format? > > > > Where is its return format documented for the withdn=t case? > > The docstring only says "If WITHDN is non-nil, each entry in the result > will be prepended with its distinguished name WITHDN.", so nowhere, > which looks like an omission. Then please document that as part of fixing the issue on master, so that it will be documented from now on. Given all the downsides, I'm okay with reverting the fix on emacs-29. Please in the future make it clear when you object to a patch, and describe its aspects to which you object. Presenting an alternative one is not enough to convey that. If I realized at the time that you are against it, especially if you'd explain why, I would have avoided wasting my time on installing it, and that would have saved us some time discussing the issue later -- a net win for everyone. Thanks.