From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Date: Tue, 22 Aug 2023 14:29:34 +0300 Message-ID: <83fs4btiw1.fsf@gnu.org> References: <87wmxrwe6h.fsf@posteo.net> <83o7j3z4wm.fsf@gnu.org> <87pm3jwboc.fsf@posteo.net> <83lee7z3xs.fsf@gnu.org> <87jztrvxx2.fsf@posteo.net> <83r0nyyhlz.fsf@gnu.org> <86o7j2qgmc.fsf@mail.linkov.net> <83cyzhwpcj.fsf@gnu.org> <87a5ultvuy.fsf@posteo.net> <83a5ulwos6.fsf@gnu.org> <87fs4bgwuj.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22202"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65380@debbugs.gnu.org, juri@linkov.net To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 22 13:30:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYPaZ-0005YW-Oe for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Aug 2023 13:30:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYPaF-00085Y-2s; Tue, 22 Aug 2023 07:30:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYPaC-00084k-2P for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 07:30:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYPaB-00026I-Qf for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 07:29:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYPaE-0001Y1-G1 for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 07:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2023 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65380-submit@debbugs.gnu.org id=B65380.16927037655885 (code B ref 65380); Tue, 22 Aug 2023 11:30:02 +0000 Original-Received: (at 65380) by debbugs.gnu.org; 22 Aug 2023 11:29:25 +0000 Original-Received: from localhost ([127.0.0.1]:58660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYPZd-0001Wr-5r for submit@debbugs.gnu.org; Tue, 22 Aug 2023 07:29:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYPZb-0001Wd-2K for 65380@debbugs.gnu.org; Tue, 22 Aug 2023 07:29:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYPZS-0001zP-E2; Tue, 22 Aug 2023 07:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VmMOfhLnwatHzuBP6KXharzbML9KN2lF7mnFk4RJ2zE=; b=X2fkjhlt0LPZ c72qZQDiqbOI36lY1lVhgKCHwHpFAENbKshmN9mzOCf9bhSYq1fc0C5HX1w8rLVF77shtt9kti8RP XfvOYNQytNthj2c+EnW10xlmb/22XFrnaj7lqj+MimAagM2Lp/Ah7gA0qdYfEGnnPjJ5K6xW83Z3P WhYUInJFdpHxRNEBs0Lok1jKhs+uG9JS/m+aaqCLjADeZXSw8QtzUl3P9Iu+y7k9Z5THhcOGK37tv 27bTUP2nGtn9Aia0pZxnTeiuorMp5NdFvzcwks6cmbfvBQMf4pqZe3p8jWnI45T6P3zEZNBF2wMtp QFB/LMi1aBlrfm0xeJfq3w==; In-Reply-To: <87fs4bgwuj.fsf@posteo.net> (message from Philip Kaludercic on Tue, 22 Aug 2023 11:06:28 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268164 Archived-At: > From: Philip Kaludercic > Cc: juri@linkov.net, 65380@debbugs.gnu.org > Date: Tue, 22 Aug 2023 11:06:28 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: Juri Linkov , 65380@debbugs.gnu.org > >> Date: Sun, 20 Aug 2023 18:24:53 +0000 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Juri Linkov > >> >> Cc: Philip Kaludercic , 65380@debbugs.gnu.org > >> >> Date: Sun, 20 Aug 2023 19:30:03 +0300 > >> >> > >> >> Regarding the implementation, there is the function > >> >> 'diff-hunk-text', but it's limited to one hunk only. > >> > > >> > So is the proposed new function, isn't it? > >> > >> No, the current proposal doesn't have any special handling for text > >> between hunks. > > > > AFAIU, the function you proposed removes the first character from each > > line in the region, so how will it handle multiple hunks? > > > > Or maybe I misunderstood what you meant by "No"? > > The command does not error when the region selects more than just a > sub-region of a hunk, but it doesn't do anything useful either. Then how about making a command that is basically a wrapper around diff-hunk-text, and allows to copy bodies of N hunks, given an argument of N? Wouldn't that be more useful?