From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 66186@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de
Subject: bug#66186: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece
Date: Mon, 25 Sep 2023 07:52:22 +0300 [thread overview]
Message-ID: <83fs323ldl.fsf@gnu.org> (raw)
In-Reply-To: <e457f8be-4d43-f649-5a13-38ea25c9dff9@gmail.com> (message from Jim Porter on Sun, 24 Sep 2023 16:02:03 -0700)
> Date: Sun, 24 Sep 2023 16:02:03 -0700
> From: Jim Porter <jporterbugs@gmail.com>
>
> > Thread 1 "emacs" received signal SIGPIPE, Broken pipe.
> > 0x00007ffff57bffef in write () from /lib/x86_64-linux-gnu/libpthread.so.0
> > #0 0x00007ffff57bffef in write () at /lib/x86_64-linux-gnu/libpthread.so.0
> > #1 0x00005555556f2f08 in emacs_full_write (fd=19, buf=0x5555565918b8 "hi", nbyte=2, interruptible=-1) at sysdep.c:2812
> [snip]
>
> Thanks. This looks like it's caused when Eshell runs a command something
> like this:
>
> echo hi | sh -c 'if [ -t 0 ]; then echo stdin; fi; ...'
>
> (Note that the pipe above is handled entirely by Eshell, using
> 'process-send-string' in this case.) I'm guessing that sometimes, the
> 'sh' process has exited by the time Eshell calls '(process-send-string
> PROC "hi")'. Presumably, the commit you identified (which just changed
> some debug logging) altered the timings by just enough to trigger this
> race condition for you.
>
> However, I don't understand why this would cause an abort though;
> normally, 'process-send-string' should just signal an Elisp error (which
> Eshell then catches and does the right thing with it). Maybe there's a
> bug somewhere in process.c where it's not correctly handling the (real)
> SIGPIPE signal and converting it to an Elisp signal?
In batch mode, SIGPIPE is not ignored by Emacs, see init_signals.
This was changed 11 years ago, see commit 4d7e6e51dd.
Perhaps Eshell should check that the process is still alive before
calling process-send-string?
next prev parent reply other threads:[~2023-09-25 4:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 21:35 bug#66186: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-24 23:02 ` Jim Porter
2023-09-25 4:52 ` Eli Zaretskii [this message]
2023-09-25 5:34 ` Jim Porter
2023-09-25 5:47 ` Jim Porter
2023-09-25 6:47 ` Eli Zaretskii
2023-09-25 7:18 ` Paul Eggert
2023-09-25 7:43 ` Eli Zaretskii
2023-09-25 19:12 ` Jim Porter
2023-09-28 20:33 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-01 20:13 ` Jim Porter
2023-09-25 9:01 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fs323ldl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66186@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.