all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: philipk@posteo.net, vekazanov@gmail.com, emacs-devel@gnu.org
Subject: Re: [ELPA] New package: ert-font-lock
Date: Sat, 18 Nov 2023 14:43:09 +0200	[thread overview]
Message-ID: <83fs13mduq.fsf@gnu.org> (raw)
In-Reply-To: <87v89zjmcx.fsf@yahoo.com> (message from Po Lu on Sat, 18 Nov 2023 20:07:42 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: Vladimir Kazanov <vekazanov@gmail.com>,  emacs-devel@gnu.org
> Date: Sat, 18 Nov 2023 20:07:42 +0800
> 
> Philip Kaludercic <philipk@posteo.net> writes:
> 
> > ELPA shouls be fine.
> 
> Since this is an adjunct to ERT, which is plausibly useful for the unit
> testing of Emacs fontification code itself, I think such code should be
> part of Emacs proper.

I won't object to including this, FWIW.

> BTW, this code requires cl-lib for a meager one macro.  Please replace
> 
>       (cl-incf curline)
> 
> with
> 
>       (setq curline (1+ curline))
> 
> that cl-lib might not be loaded either at compile-time or runtime.
> There is no rationale for requiring cl-lib so as to employ a single
> macro once.

Doesn't this library require ert?  if it does, cl-lib is already
loaded by ert.

But if people like cl-incf so much, we could just add incf to subr.el
or something.



  reply	other threads:[~2023-11-18 12:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18 10:43 [ELPA] New package: ert-font-lock Vladimir Kazanov
2023-11-18 11:18 ` Philip Kaludercic
2023-11-18 12:07   ` Po Lu
2023-11-18 12:43     ` Eli Zaretskii [this message]
2023-11-18 13:14       ` Po Lu
2023-11-18 14:47         ` Philip Kaludercic
2023-11-18 16:23           ` Eli Zaretskii
2023-11-19  9:39           ` Vladimir Kazanov
2023-11-18 14:18       ` john muhl
2023-11-19 10:02         ` Vladimir Kazanov
2023-11-19 10:08       ` Vladimir Kazanov
2023-11-20 18:27         ` Vladimir Kazanov
2023-11-21  4:45           ` john muhl
2023-11-21  7:43             ` Vladimir Kazanov
2023-11-21 16:51               ` john muhl
2023-11-23 13:00                 ` Vladimir Kazanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fs13mduq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=philipk@posteo.net \
    --cc=vekazanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.