From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: desktop fails to restore dired buffers Date: Thu, 07 Dec 2023 09:24:39 +0200 Message-ID: <83fs0e326g.fsf@gnu.org> References: <86jzpr3trn.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22224"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andy Moreton , Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 07 08:25:15 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rB8l0-0005Vj-9K for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Dec 2023 08:25:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB8kO-0000pa-7K; Thu, 07 Dec 2023 02:24:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB8kE-0000p0-W9 for emacs-devel@gnu.org; Thu, 07 Dec 2023 02:24:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB8kE-0000oP-HJ; Thu, 07 Dec 2023 02:24:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PCnWbb5a9MjHIaH4vTNg8dcIaeCPMndO5XQUOP2P8Wc=; b=dhl4IU3UxUh9 QipR39On4kvD2UB1VqpRqrTKhRYReTCg64aymlwPfTOfys2jjbWvaKGxtUIixo2VoMokLTeyUIYaS Ohdg1AFe5aGJxAybfyWBDcYVsLM595z4BZqSGMqNRpS+oOPRlU/8+1vrBVca0k8/P/Punn6zIqSJv SoZB6OvfWwNqOTzNx+efB9xiFE4K5Yh8ocFMZrb8oBitIrQ7CepgZYTS5DwCuXdDemCllBhQjlwOS hdbBhsyZPI0iGtcJoo4hY37S38PU9eU7CIdEZu+/QWbWKHV3MPhgeBeLHH6W6+BQ5ObgtDOuulfz1 QeIpfMBkJ7oufWgp1zEqPg==; In-Reply-To: <86jzpr3trn.fsf@gmail.com> (message from Andy Moreton on Wed, 06 Dec 2023 21:28:44 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313583 Archived-At: > From: Andy Moreton > Date: Wed, 06 Dec 2023 21:28:44 +0000 > > > Commit ce4a62eece60 ("Fix desktop-save on remote dired (bug#66697)") on > the master branch changed how dired buffers are saved by desktop-save, > so they are no longer restored in my setup. > > The code in `dired-desktop-save-p' and `dired-desktop-buffer-misc-data' > now assumes that `desktop-files-not-to-save' always has a string value. > > However I have `desktop-files-not-to-save' as nil, which is a valid > value according to its definition. That fails the checks, and so > dired buffers are not saved. > > Please can this oversight be fixed ? Manuel, could you please look into this issue? P.S. This should have been posted to the bug tracker, not here.