From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master d9b5f618baa 2/4: Eglot: introduce eglot-events-buffer-config Date: Wed, 27 Dec 2023 20:51:54 +0200 Message-ID: <83frzn8omt.fsf@gnu.org> References: <83le9f8ufh.fsf@gnu.org> <83il4j8sgf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 27 19:53:18 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIZ1p-0002R9-CA for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Dec 2023 19:53:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIZ0o-0006lD-8J; Wed, 27 Dec 2023 13:52:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIZ0l-0006kl-Al for emacs-devel@gnu.org; Wed, 27 Dec 2023 13:52:11 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIZ0k-00010u-Ld; Wed, 27 Dec 2023 13:52:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RYetF/JUC9KZB4BXqKE6Hf+Al6AcFekPS2qtddfTkug=; b=RCbqJ4ZkA9jdj/p+I8za tBdTBeVFRfc8wDiYmHDVvfLQ7Gp5MxOsEgkw9uk9bOAHxtXpjM2Hd5SuU1cp5gcF7LjPWmrEFyAtI Od2jZD1QR+MfpAWBmTyFLDLsW/oQeZY26+l+WjGbTWvJ77iiVesMbdE51blE5KClpwyNmesdMQDoZ jRoCFSepkDNkVxAJzU/OedQtd6f0XSaVjATINC1QUp3KgcggIhzlZzelGav9A4I53Na7E4OC4z3LA 4X5EJh3BdjwvulBu0urLueFFeAqh4FXkYf0smSD35nWUiZ9V+pzB4cZBFs9vKUtxhcsIia4KIg8kT qJC87H+3MzruCw==; In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Wed, 27 Dec 2023 17:38:13 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314255 Archived-At: > From: João Távora > Date: Wed, 27 Dec 2023 17:38:13 +0000 > Cc: emacs-devel@gnu.org > > On Wed, Dec 27, 2023 at 5:29 PM Eli Zaretskii wrote: > > > > IOW Reconnecting to a server may trash useful caches, fail due > > > to numerous reasons, etc... We don't want to initiate it just > > > because a user changed a preference. > > > > Shouldn't these caveats be in the doc string, where you tell users to > > invoke eglot-reconnect? > > No. It's too server-specific, every server can behave differently. It's > assumed that if a user wants to reconnect and interactively chooses to do > that, it's because they want to and understand what it does. The model > is the same as in SLIME and SLY, which also work with a multitude of CL > implementations, and it has never proven problematic to my knowledge > (at least in a over a decade of SLY maintenance). Then we are inconsistent: either running eglot-reconnect is mostly okay, in which case we should do it automatically when the option's value changes, or it has issues, in which case we should at least hint on those issues in the doc string, perhaps saying that with some servers it's okay and with others less so. The way the doc string is worded now, users will invoke eglot-reconnect without being aware of the possible issues which are the reason that you are reluctant to invoke eglot-reconnect automatically.