From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: artist-mouse-choose-operation Date: Fri, 13 Nov 2009 12:34:34 +0200 Message-ID: <83eio2ogqt.fsf@gnu.org> References: <834opfeq8a.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1258108717 23643 80.91.229.12 (13 Nov 2009 10:38:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2009 10:38:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tomas Abrahamsson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 13 11:38:30 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N8tXx-0006a1-Ug for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2009 11:38:30 +0100 Original-Received: from localhost ([127.0.0.1]:46156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8tXx-0007BP-El for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2009 05:38:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8tXH-0006kd-Bv for emacs-devel@gnu.org; Fri, 13 Nov 2009 05:37:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8tXC-0006ht-Ml for emacs-devel@gnu.org; Fri, 13 Nov 2009 05:37:46 -0500 Original-Received: from [199.232.76.173] (port=44955 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8tXC-0006hc-Ar for emacs-devel@gnu.org; Fri, 13 Nov 2009 05:37:42 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:57058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8tXB-00066t-Bv for emacs-devel@gnu.org; Fri, 13 Nov 2009 05:37:42 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KT100C00MK86I00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Fri, 13 Nov 2009 12:36:30 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KT1007V9MSTXZ90@a-mtaout22.012.net.il>; Fri, 13 Nov 2009 12:36:30 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116937 Archived-At: > From: Tomas Abrahamsson > Cc: emacs-devel@gnu.org > Date: Mon, 09 Nov 2009 23:22:11 +0100 > > Eli Zaretskii writes: > > > The function in the Subject calls x-popup-menu, evidently under the > > assumption that if Emacs can use a mouse, it also supports menus. But > > that assumption is false: Emacs configured --without-x can have mouse > > support, e.g. via gpm-mouse, but does not have x-popup-menu. > > Yes, I agree this is a bug. Below is a patch for fixing the bug and a > proposal for a ChangeLog entry. > > * textmodes/artist.el (artist-mouse-choose-operation) call > `tmm-prompt' instead of `x-popup-menu' if we cannot popup > menus. Bug noticed by Eli Zaretskii . > > * textmodes/artist.el (artist-mouse-choose-operation) > (artist-down-mouse-1): call (new) function > `artist-compute-up-event-key'. > > The patch is against the latest from the git/cvs repository as of > yesterday (Sunday). The patch is made by me. Thanks, I installed this in CVS.