From: Eli Zaretskii <eliz@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cschol2112@googlemail.com, lekktu@gmail.com,
sean.sieger@gmail.com, 7167-done@debbugs.gnu.org
Subject: bug#7167: 23.2; w32-shell-execute doc
Date: Fri, 08 Oct 2010 11:52:47 +0200 [thread overview]
Message-ID: <83eic1nh8w.fsf@gnu.org> (raw)
In-Reply-To: <83pqvloork.fsf@gnu.org>
> Date: Thu, 07 Oct 2010 20:12:47 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: cschol2112@googlemail.com, sean.sieger@gmail.com, 7167@debbugs.gnu.org
>
> > From: Juanma Barranquero <lekktu@gmail.com>
> > Date: Thu, 7 Oct 2010 12:15:55 +0200
> > Cc: Sean Sieger <sean.sieger@gmail.com>, 7167@debbugs.gnu.org
> >
> > [Sean, I've Cc:ed you because you're doing binary tarballs now]
> >
> > On Thu, Oct 7, 2010 at 05:57, Christoph <cschol2112@googlemail.com> wrote:
> >
> > > Juanma, let me know if I can help troubleshoot this.
> >
> > I think it is an issue with the binary distribution of Emacs 23.2 for
> > Windows, not with 23.2 per se, because I have my own build of it and
> > the problem is not present.
> >
> > Likely the fix will simply be to rebuild the official binary
> > distribution of 23.2.
>
> Not sure, because my binary, which I built myself, also has this
> problem.
>
> Will try to investigate tomorrow.
Found the problem. There's nothing wrong with the Windows build
system per se. The problem is that emacs-23.2 tarball comes with a
src/buildobj.h from a Unix system where it was tarred, which is
baaaaad, and not only on Windows. This causes Make not to create
src/buildobj.h as suitable for the actual build on the target
platform, and the rest is history.
I've just installed a fix in the emacs-23 branch (revno 100091 and a
followup change in 100092) to exclude this file from the tarball.
To fix this locally, just remove src/buildobj.h and rebuild Emacs.
While at that, I would suggest that this code in help-fns.el:
(let ((file (catch 'loop
(while t
(let ((pnt (search-forward (concat "\x1f" name "\n"))))
(re-search-backward "\x1fS\\(.*\\)")
(let ((file (match-string 1)))
(if (member file build-files)
(throw 'loop file)
(goto-char pnt))))))))
(if (string-match "^ns.*\\(\\.o\\|obj\\)\\'" file)
(setq file (replace-match ".m" t t file 1))
(if (string-match "\\.\\(o\\|obj\\)\\'" file)
(setq file (replace-match ".c" t t file))))
(if (string-match "\\.\\(c\\|m\\)\\'" file)
(concat "src/" file)
file)))))
be made smarter wrt the error message it displays when the function or
variable it looks for is found in etc/DOC, but the file in which it is
defined is not in build-files. (This happens when you click or type
RET on the link to the source file where the function is defined.)
Currently, the error message, which comes from search-forward, is
quite cryptic for a naive user:
Search failed: "^_Fw32-shell-execute
"
It should at least mention the fact that the problem could be with
build-files, or, better, say that w32-shell-execute's definition is in
a file that is not in build-files. Volunteers are welcome to make
this improvement.
next prev parent reply other threads:[~2010-10-08 9:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 14:46 bug#7167: 23.2; w32-shell-execute doc Mirko Vukovic
2010-10-06 18:27 ` Juanma Barranquero
2010-10-07 3:42 ` Christoph
2010-10-07 3:57 ` Christoph
2010-10-07 10:15 ` Juanma Barranquero
2010-10-07 10:44 ` Lennart Borgman
2010-10-07 10:46 ` Juanma Barranquero
2010-10-07 10:50 ` Lennart Borgman
2010-10-07 10:56 ` Juanma Barranquero
2010-10-07 11:53 ` Lennart Borgman
2010-10-07 12:03 ` Juanma Barranquero
2010-10-07 14:18 ` Jason Rumney
2010-10-07 18:19 ` Eli Zaretskii
2010-10-07 20:50 ` Sean Sieger
2010-10-07 18:12 ` Eli Zaretskii
2010-10-08 9:52 ` Eli Zaretskii [this message]
2010-10-08 10:34 ` Lennart Borgman
2010-10-08 15:08 ` Ken Brown
2010-10-07 20:53 ` Sean Sieger
2010-10-07 15:01 ` Esa Peuha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eic1nh8w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=7167-done@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
--cc=lekktu@gmail.com \
--cc=sean.sieger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.