Re: [PATCH 4/4] Fix emacsclient to work with cygw32

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 29 Dec 2011 09:56:43 -0800
> From: Daniel Colascione <dancol@dancol.org>
> CC: emacs-devel@gnu.org
> 
> 
> [1:text/plain Hide]
> 
> On 12/29/11 9:39 AM, Eli Zaretskii wrote:
> >> Date: Thu, 29 Dec 2011 06:03:20 -0800
> >> From: Daniel Colascione <dancol@dancol.org>
> >>
> >> @@ -184,7 +188,7 @@ struct option longopts[] =
> >>    { "socket-name",	required_argument, NULL, 's' },
> >>  #endif
> >>    { "server-file",	required_argument, NULL, 'f' },
> >> -#ifndef WINDOWSNT
> >> +#ifndef HAVE_NTGUI
> >>    { "display",	required_argument, NULL, 'd' },
> >>  #endif
> > 
> > Maybe I'm confused: will HAVE_NTGUI be applicable to the Cygwin build
> > that can use the w32 windowing?  If so, it sounds like you are
> > creating here 2 kinds of emacsclient: one that can talk to a Cygwin
> > Emacs with X frames on another display, the other that cannot.  Why
> > cannot the same emacsclient work with both types of Emacs frames in a
> > Cygwin Emacs?
> > 
> > Apologies if I've misread the changes.
> 
> No, you're right.  I was following the template of the existing code
> here; IIUC, removing the conditional in the hunk above will let the same
> emacsclient talk to any kind of Emacs.

But the ifdef-out must stay in the native w32 build, I think, because
it causes trouble further down the line.  Juanma, can you comment,
please?