From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11068: 24.0.94; Face-remapped background does not extend to end of window Date: Sat, 24 Mar 2012 16:40:37 +0200 Message-ID: <83ehsit63e.fsf@gnu.org> References: <1BE52A40-0403-433F-8164-DFDBD6771F80@gmail.com> <83ty1fvc28.fsf@gnu.org> <83obrmtbsy.fsf@gnu.org> <87ty1ekrqy.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1332600132 14882 80.91.229.3 (24 Mar 2012 14:42:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2012 14:42:12 +0000 (UTC) Cc: darthandrus@gmail.com, 11068@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 24 15:42:10 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBSAT-0008CR-L4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 15:42:09 +0100 Original-Received: from localhost ([::1]:57282 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBSAS-00068F-NM for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 10:42:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBSAQ-00068A-EO for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:42:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBSAO-0004dW-Mx for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:42:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBSAO-0004bc-JK for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBSeM-0000uE-DF for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Mar 2012 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11068-submit@debbugs.gnu.org id=B11068.13326019343429 (code B ref 11068); Sat, 24 Mar 2012 15:13:02 +0000 Original-Received: (at 11068) by debbugs.gnu.org; 24 Mar 2012 15:12:14 +0000 Original-Received: from localhost ([127.0.0.1]:37013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBSdZ-0000tF-ID for submit@debbugs.gnu.org; Sat, 24 Mar 2012 11:12:14 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:63773) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBSd0-0000sG-9N for 11068@debbugs.gnu.org; Sat, 24 Mar 2012 11:12:11 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M1E00G0089HW300@a-mtaout22.012.net.il> for 11068@debbugs.gnu.org; Sat, 24 Mar 2012 16:40:38 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.240.24]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M1E00G8O8RPAZF0@a-mtaout22.012.net.il>; Sat, 24 Mar 2012 16:40:38 +0200 (IST) In-reply-to: <87ty1ekrqy.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58085 Archived-At: > From: Chong Yidong > Cc: darthandrus@gmail.com, Stefan Monnier , 11068@debbugs.gnu.org > Date: Sat, 24 Mar 2012 22:17:41 +0800 > > Eli Zaretskii writes: > > > /* Face extension extends the background and box of IT->face_id > > to the end of the line. If the background equals the background > > of the frame, we don't have to do anything. */ > > if (it->face_before_selective_p) > > face = FACE_FROM_ID (f, it->saved_face_id); > > + else if (it->face_id == DEFAULT_FACE_ID) > > + face = default_face; > > else > > face = FACE_FROM_ID (f, it->face_id); > > This looks a bit strange. Why is DEFAULT_FACE_ID handled specially > here? In my testing, I didn't see the need to do it even for the default face, because it->face_id is already set to the ID of the remapped face. So it's just me being paranoiac. Because of this condition, immediately below the fragment you cited: if (FRAME_WINDOW_P (f) && it->glyph_row->displays_text_p && face->box == FACE_NO_BOX && face->background == FRAME_BACKGROUND_PIXEL (f) && !face->stipple && !it->glyph_row->reversed_p) return; Any non-default face would already penetrate this condition > Shouldn't we be checking for face remapping no matter what the > face_id is? The remapping takes place before we hit this function, which is at the end of displaying a line. So the face is already remapped.