all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: 12839@debbugs.gnu.org
Subject: bug#12839: 24.3.50; Emacs aborts in GC
Date: Fri, 09 Nov 2012 16:16:49 +0200	[thread overview]
Message-ID: <83ehk2zwry.fsf@gnu.org> (raw)
In-Reply-To: <509D0266.807@yandex.ru>

> Date: Fri, 09 Nov 2012 17:17:26 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: 12839@debbugs.gnu.org
> 
> On 11/09/2012 11:24 AM, Eli Zaretskii wrote:
> 
> > I'd be happy to try debugging this myself, but I need guidance
> > regarding some basics of what you changed recently in this area.
> > Alternatively, tell me what to do in GDB, and I will post the results.
> > I'm quite fluent with GDB, and reproducing this is extremely easy :-(.
> 
> Try this:
> 
> === modified file 'src/w32term.h'
> --- src/w32term.h	2012-10-17 19:02:44 +0000
> +++ src/w32term.h	2012-11-09 13:13:43 +0000
> @@ -414,10 +414,8 @@
>      vector.  */
> 
>   struct scroll_bar {
> -
> -  /* These fields are shared by all vectors.  */
> -  EMACS_INT size_from_Lisp_Vector_struct;
> -  struct Lisp_Vector *next_from_Lisp_Vector_struct;
> +  /* This field is shared by all vectors.  */
> +  struct vectorlike_header header;
> 
>     /* The window we're a scroll bar for.  */
>     Lisp_Object window;

I applied this together with the other patch you sent, and the 2
crashes I saw earlier do not happen anymore.  Thanks.

> This is Windows-specific and obviously wrong since sizeof (struct vectorlike_header)
> is now _less than_ sizeof (EMACS_INT) + sizeof (struct Lisp_Vector *).

If it's wrong, why use it?  What would be the right change?





  parent reply	other threads:[~2012-11-09 14:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 17:12 bug#12839: 24.3.50; Emacs aborts in GC Eli Zaretskii
2012-11-08 22:05 ` Eli Zaretskii
2012-11-09  3:40   ` Dmitry Antipov
2012-11-09  7:24     ` Eli Zaretskii
2012-11-09  8:56       ` Eli Zaretskii
2012-11-09 12:44       ` Dmitry Antipov
2012-11-09 14:47         ` Eli Zaretskii
2012-11-09 13:17       ` Dmitry Antipov
2012-11-09 13:27         ` Dmitry Antipov
2012-11-09 14:16         ` Eli Zaretskii [this message]
2012-11-09 14:46           ` Dmitry Antipov
2012-11-09 14:53             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ehk2zwry.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12839@debbugs.gnu.org \
    --cc=dmantipov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.