From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: fni@missioncriticalit.com, 12832@debbugs.gnu.org
Subject: bug#12832: 24.3.50; Emacs lockup when idle
Date: Tue, 13 Nov 2012 19:04:48 +0200 [thread overview]
Message-ID: <83ehjxv3gv.fsf@gnu.org> (raw)
In-Reply-To: <50A26E9E.4020405@gmail.com>
Can you please try the patch below and see if it prevents the
lock-ups?
=== modified file 'src/w32proc.c'
--- src/w32proc.c 2012-11-05 03:18:32 +0000
+++ src/w32proc.c 2012-11-13 16:59:53 +0000
@@ -431,13 +431,24 @@ timer_loop (LPVOID arg)
/* Simulate a signal delivered to the thread which installed
the timer, by suspending that thread while the handler
runs. */
- DWORD result = SuspendThread (itimer->caller_thread);
+ DWORD result;
+
+ if (dwMainThreadId)
+ enter_crit ();
+ result = SuspendThread (itimer->caller_thread);
if (result == (DWORD)-1)
- return 2;
+ {
+ if (dwMainThreadId)
+ leave_crit ();
+ return 2;
+ }
handler (sig);
ResumeThread (itimer->caller_thread);
+
+ if (dwMainThreadId)
+ leave_crit ();
}
/* Update expiration time and loop. */
next prev parent reply other threads:[~2012-11-13 17:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 12:57 bug#12832: 24.3.50; Emacs lockup when idle Andy Moreton
2012-11-08 16:28 ` Eli Zaretskii
2012-11-08 18:33 ` Andy Moreton
2012-11-09 9:56 ` Eli Zaretskii
2012-11-09 10:48 ` Andy Moreton
2012-11-09 11:14 ` Eli Zaretskii
2012-11-09 18:11 ` Eli Zaretskii
2012-11-09 18:38 ` Andy Moreton
2012-11-09 19:12 ` Eli Zaretskii
2012-11-09 19:15 ` Eli Zaretskii
2012-11-13 12:59 ` Eli Zaretskii
[not found] ` <509BAC2E.2000702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-13 13:13 ` Fabrice Niessen
2012-11-13 13:39 ` Dani Moncayo
2012-11-13 14:07 ` Eli Zaretskii
2012-11-13 14:25 ` Andy Moreton
2012-11-13 15:16 ` Eli Zaretskii
2012-11-13 16:00 ` Andy Moreton
2012-11-13 16:35 ` Eli Zaretskii
2012-11-13 16:40 ` Andy Moreton
2012-11-13 17:20 ` Eli Zaretskii
2012-11-13 17:04 ` Eli Zaretskii [this message]
2012-11-14 12:44 ` Andy Moreton
2012-11-14 16:29 ` Andy Moreton
2012-11-14 16:48 ` Lennart Borgman
2012-11-14 17:41 ` Eli Zaretskii
2012-11-14 17:49 ` Lennart Borgman
2012-11-14 17:53 ` Eli Zaretskii
2012-11-14 16:51 ` Eli Zaretskii
2012-11-14 20:17 ` Andy Moreton
2012-11-15 19:26 ` Andy Moreton
2012-11-15 20:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ehjxv3gv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12832@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=fni@missioncriticalit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.