From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 14295@debbugs.gnu.org
Subject: bug#14295: Support copy-file ACLs for Solaris etc.
Date: Mon, 29 Apr 2013 20:07:43 +0300 [thread overview]
Message-ID: <83ehdtqn8g.fsf@gnu.org> (raw)
In-Reply-To: <517E0FEA.2000500@cs.ucla.edu>
> Date: Sun, 28 Apr 2013 23:15:06 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: bug-gnu-emacs@gnu.org
>
> > How hard would it to support both?
>
> I don't know, and I'd rather not support --without-acl. This should
> have been an --enable/--disable option in the first place, as it's
> enabling or disabling a feature, not building with or without a
> package. There's little point to Emacs departing from existing
> GNU practice here.
I just wonder how many people are used to that option. Maybe not too
many, since this is a new feature.
> > This uses EOPNOTSUPP without #ifdef guards; is that universally
> > available?
>
> Mostly, except for Windows, but to play it safe we can incorporate the
> Gnulib errno module, which defines EOPNOTSUPP if it's not already
> defined.
That almost works, but there are 2 issues:
. I'd prefer to have the definition of EOPNOTSUPP in nt/inc/ms-w32.h,
to make synchronization of config.nt with src/config.in easier.
. More importantly, ENOTSUP is defined on Windows with the same value
as ENOSYS (see ms-w32.h), so acl-errno-valid.c will fail to compile
due to 2 identical case values in a switch.
> > If I'm right, perhaps it is best to leave the WINDOWSNT parts alone:
>
> Sure, we can do that.
Thanks.
> OK. Revised patch attached, which tries to address the above.
It looks fine, other than the 2 minor issues above, thanks.
> It relies on Gnulib for EOPNOTSUPP, except for WINDOWSNT where
> 'configure' isn't working yet, and there it adds a line to
> nt/config.nt to deal with this until we get 'configure' working.
'configure' is already working, I just need time to finish up the
branch and merge it. But even when that is done (hopefully in a few
days), we will not immediately abandon the current configury. It will
take some time.
next prev parent reply other threads:[~2013-04-29 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 3:33 bug#14295: Support copy-file ACLs for Solaris etc Paul Eggert
2013-04-28 17:16 ` Eli Zaretskii
2013-04-29 6:15 ` Paul Eggert
2013-04-29 17:07 ` Eli Zaretskii [this message]
2013-05-07 21:36 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ehdtqn8g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14295@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.