From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Date: Sun, 15 Sep 2013 09:20:23 +0300 Message-ID: <83eh8qfvx4.fsf@gnu.org> References: <8761u5rl5c.fsf@yandex.ru> <83zjrghnca.fsf@gnu.org> <5233B818.5050705@yandex.ru> <838uyzhlv5.fsf@gnu.org> <52341F9A.6030102@gmx.at> <837gejhj7v.fsf@gnu.org> <523430BB.2070902@gmx.at> <83y56zg13n.fsf@gnu.org> <52345FC1.3020305@yandex.ru> <83txhnfrer.fsf@gnu.org> <52352309.70507@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1379226076 1055 80.91.229.3 (15 Sep 2013 06:21:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Sep 2013 06:21:16 +0000 (UTC) Cc: 15365@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 15 08:21:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VL5ht-00037a-1w for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2013 08:21:17 +0200 Original-Received: from localhost ([::1]:55547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VL5hs-0005b8-6z for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Sep 2013 02:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VL5hk-0005b1-00 for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 02:21:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VL5hf-0001pa-4g for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 02:21:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VL5hf-0001pW-0m for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 02:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VL5he-0006MD-Ll for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2013 02:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Sep 2013 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15365-submit@debbugs.gnu.org id=B15365.137922604824408 (code B ref 15365); Sun, 15 Sep 2013 06:21:02 +0000 Original-Received: (at 15365) by debbugs.gnu.org; 15 Sep 2013 06:20:48 +0000 Original-Received: from localhost ([127.0.0.1]:37832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VL5hO-0006Lb-ER for submit@debbugs.gnu.org; Sun, 15 Sep 2013 02:20:47 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:63611) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VL5hH-0006LI-0A for 15365@debbugs.gnu.org; Sun, 15 Sep 2013 02:20:41 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MT500I00LIL4J00@a-mtaout22.012.net.il> for 15365@debbugs.gnu.org; Sun, 15 Sep 2013 09:20:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT500H58LM6IUD0@a-mtaout22.012.net.il>; Sun, 15 Sep 2013 09:20:31 +0300 (IDT) In-reply-to: <52352309.70507@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78416 Archived-At: > Date: Sun, 15 Sep 2013 06:01:29 +0300 > From: Dmitry Gutov > CC: rudalics@gmx.at, 15365@debbugs.gnu.org > > On 14.09.2013 16:45, Eli Zaretskii wrote: > >> I've been using `vc-git-log-edit-toggle-amend' without crashes for > >> nearly a year now, since it's been added. > > > > If you can identify the last revision where this abort didn't happen, > > I could try figuring out what changed. > > It's 114149. Thanks, I will have a look. Do the situations that triggered the bug involve font changes? (The revision you pointed to made tracking of font changes be per frame, rather than global.) In any case, that revision was about making redisplay optimizations more aggressive, so it is small wonder that try_window_id, which is part of those optimizations, is now called in situations where previously it wasn't. IOW, it is quite possible that there's nothing wrong with try_window_id being invoked in these situations. > (TIL that 'git bisect', unlike its Bazaar counterpart, supports > filtering commits by files they touched. xdisp.c, in this example). The display engine is not limited to xdisp.c; dispnew.c and dispextern.h are important parts of it, and sometimes window.c and the display-specific back-ends (xterm.c and xfns.c for X and similarly for w32 and NS) are also involved. > >> Why scratch? > > > > Because it could be messed up by the testing. > > None of GitHub repositories are publicly writable, so there's zero > danger of that. Thanks, I didn't know that. (Of course, I never had to use GitHub, either.) > > I don't know how to make sure my commits are never pushed. > > Aside from you not having commit rights, Git doesn't have anything > analogous to Bzr's bound branches built-in, so 'git push' always has to > be called explicitly (or one can write a custom hook). I know about "git push" vs "git commit". What I didn't know is what exactly do the Emacs commands you used do, in git terms, and how does that relate to commit and push and the myriad of their options. The only thing that was clear to me was that a commit is required, because that's what "C-x v v" does in a modified buffer. I know nothing about "C-c C-e" in that context. And even if I knew that "push" is not involved, committing to a repository that tracks upstream development (which is all I do with git) would need some way to subsequently un-commit that, something I don't know how to do with git. I didn't want to screw up my work on GNU Make and Gawk, I'm sure you will understand.