From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: ran@lasgalen.net, 16133@debbugs.gnu.org
Subject: bug#16133: 24.3; copy-file fails on chmod when copying to FAT filesystem
Date: Sun, 22 Dec 2013 20:35:39 +0200 [thread overview]
Message-ID: <83eh5491j8.fsf@gnu.org> (raw)
In-Reply-To: <52B72356.7000103@cs.ucla.edu>
> Date: Sun, 22 Dec 2013 09:37:26 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: 16133@debbugs.gnu.org, ran@lasgalen.net
>
> Eli Zaretskii wrote:
> > I was referring to the use case described here:
> >
> > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16133#14
> >
> > The 'cp' equivalent of that is when it is invoked to copy more than
> > one file, or copy a directory.
>
> The use case described there does not involve merely copy-file;
> it also involves some other function (org-mobile-push, I guess)
> that uses copy-file to copy files one at a time,
> and which gives up if one instance of copy-file fails.
>
> This is akin to a shell script that uses cp to
> copy files one a time, and which aborts if cp fails.
> Such a script would behave the same way that org-mobile-push
> behaves now, if I'm understanding the bug report correctly.
>
> One fix would be to modify org-mobile-push to not throw an error
> when copy-file fails, but instead to continue. Perhaps this is the
> desired behavior, not only for fchmod failure, but for other copy-file
> failures such as write error. In any case org-mobile-push could
> ignore some or all errors, or report them at the end, or whatever
> it likes.
Sorry, I disagree: it is not the business of copy-file to decide when
to interrupt its caller. It is only justified to do that when the
error is fatal; this one isn't: the file was copied.
copy-file is akin to a library function. A library function should
never decide on its own when to call it quits, because a library
function never has enough context to do TRT.
next prev parent reply other threads:[~2013-12-22 18:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 19:51 bug#16133: 24.3; copy-file fails on chmod when copying to FAT filesystem Artem Chuprina
2013-12-13 22:51 ` Glenn Morris
2013-12-13 22:55 ` Glenn Morris
2013-12-14 10:10 ` Artem Chuprina
2013-12-14 20:19 ` Glenn Morris
2013-12-14 20:46 ` Josh
2013-12-14 20:57 ` Eli Zaretskii
2013-12-14 21:21 ` Josh
2013-12-15 3:44 ` Eli Zaretskii
2013-12-14 20:55 ` Eli Zaretskii
2013-12-14 21:07 ` Achim Gratz
2013-12-15 14:38 ` Artem Chuprina
2013-12-16 14:15 ` Stefan Monnier
2013-12-20 23:27 ` Paul Eggert
2013-12-22 0:01 ` Paul Eggert
2013-12-22 3:47 ` Eli Zaretskii
2013-12-22 4:01 ` Paul Eggert
2013-12-22 15:50 ` Artem Chuprina
2013-12-22 19:03 ` Paul Eggert
2013-12-22 20:13 ` Artem Chuprina
2013-12-23 23:58 ` Paul Eggert
2013-12-24 6:52 ` Artem Chuprina
2013-12-24 9:58 ` Andreas Schwab
2013-12-24 10:22 ` Artem Chuprina
2013-12-24 17:39 ` Paul Eggert
2013-12-24 16:51 ` Artem Chuprina
2013-12-29 18:31 ` Paul Eggert
2013-12-22 16:24 ` Eli Zaretskii
2013-12-22 17:37 ` Paul Eggert
2013-12-22 18:35 ` Eli Zaretskii [this message]
2013-12-22 18:54 ` Paul Eggert
2013-12-22 20:32 ` Artem Chuprina
2013-12-22 21:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eh5491j8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16133@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=ran@lasgalen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.