From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-24 r117265: Fix bug #17801 with extraneous newlines after inserting markup in Texinfo mode.
Date: Fri, 20 Jun 2014 22:24:14 +0300 [thread overview]
Message-ID: <83egyjqt9d.fsf@gnu.org> (raw)
In-Reply-To: <jwvfvizpomh.fsf-monnier+emacsdiffs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Fri, 20 Jun 2014 11:50:40 -0400
>
> >> > - \n _ \n "@end " str \n)
> >> > + \n _ \n "@end " str \n \n)
> >> I think these extra \n should not be added.
> > If you mean that "\n" should have been used instead, then I agree and
> > will change these. But if you mean these skeletons should not insert
> > newlines unconditionally, then please explain, because I tested these
> > changes and found them to DTRT.
>
> I think they should end with a single \n and nothing more, so they won't
> add a newline when there's one already.
I added another \n in 4 cases: texinfo-insert-block,
texinfo-insert-@end, texinfo-insert-@example, and
texinfo-insert-@quotation. All of these should have an empty line
after them. So I think I disagree with what you say, and these
changes are actually correct.
In any case, "at eol" and "there is already a newline" is not the
same. skeleton.el tests the former, which doesn't mean there's a
newline.
next prev parent reply other threads:[~2014-06-20 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WxuUZ-0005uP-MW@vcs.savannah.gnu.org>
2014-06-20 13:39 ` [Emacs-diffs] emacs-24 r117265: Fix bug #17801 with extraneous newlines after inserting markup in Texinfo mode Stefan Monnier
2014-06-20 14:23 ` Eli Zaretskii
2014-06-20 15:50 ` Stefan Monnier
2014-06-20 19:24 ` Eli Zaretskii [this message]
2014-06-20 21:12 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83egyjqt9d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.