From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18610: 24.4.50; Specific file causing emacs to segfault upon opening Date: Mon, 06 Oct 2014 18:20:08 +0300 Message-ID: <83egulmdhz.fsf@gnu.org> References: <87a959ti1h.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1412608884 26555 80.91.229.3 (6 Oct 2014 15:21:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Oct 2014 15:21:24 +0000 (UTC) Cc: dmantipov@yandex.ru, maden.ldm@gmail.com, 18610@debbugs.gnu.org To: handa@gnu.org (K. Handa) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 06 17:21:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XbA68-0002wr-Oi for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Oct 2014 17:21:16 +0200 Original-Received: from localhost ([::1]:52507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbA68-0004cm-C3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Oct 2014 11:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbA5z-0004cH-Se for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2014 11:21:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XbA5u-0004LV-Dc for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2014 11:21:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbA5u-0004LC-AJ for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2014 11:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XbA5t-0005f6-Kr for bug-gnu-emacs@gnu.org; Mon, 06 Oct 2014 11:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Oct 2014 15:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18610-submit@debbugs.gnu.org id=B18610.141260883221717 (code B ref 18610); Mon, 06 Oct 2014 15:21:01 +0000 Original-Received: (at 18610) by debbugs.gnu.org; 6 Oct 2014 15:20:32 +0000 Original-Received: from localhost ([127.0.0.1]:35917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbA5P-0005eC-13 for submit@debbugs.gnu.org; Mon, 06 Oct 2014 11:20:31 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:55998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XbA5L-0005dz-Bc for 18610@debbugs.gnu.org; Mon, 06 Oct 2014 11:20:29 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0ND100B003U4RT00@a-mtaout22.012.net.il> for 18610@debbugs.gnu.org; Mon, 06 Oct 2014 18:19:59 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ND100B3B3XBKQ50@a-mtaout22.012.net.il>; Mon, 06 Oct 2014 18:19:59 +0300 (IDT) In-reply-to: <87a959ti1h.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94205 Archived-At: > From: handa@gnu.org (K. Handa) > Cc: dmantipov@yandex.ru, maden.ldm@gmail.com, 18610@debbugs.gnu.org > Date: Mon, 06 Oct 2014 23:00:10 +0900 > > In article <83zjdamrbd.fsf@gnu.org>, Eli Zaretskii writes: > > > > No. Even if there's no special ISO-2022 escape sequence, we > > > should not reject iso-2022 as a detected coding system. > > > Can you explain why? AFAICT, all the other detectors are required to > > set some flag in the 'found' field, so why is ISO-2022 special in this > > regard? > > Because the file contains the byte #x96 which is included in > latin-extra-code-table (i.e. (aref latin-extra-code-table > #x96) is t). Yes, but what's the reason for having latin-extra-code-table in the first place? > > Btw, it would be nice if these masks could be documented so that their > > meaning was clear. I considered the possibility that the flags are > > not set correctly, but couldn't test that hypothesis given my > > insufficient knowledge of ISO-2022 details and variants. > > Sorry for the poor comments in my code. I'll work on it soon. TIA. > > would set the buffer-file-coding-system of the buffer > > visiting the file to 'undecided', and regarded the \226 > > characters as 8-bit raw bytes: > > I think that is a bug. If the file doesn't contain ESC, it > is detected as latin-1. If the file contains latin-1 byte > 0xA0..0xFF instead of \226, it is detected as latin-1. So, > as far as \226 is treated as extra latin code, it should be > decoded as latin-1. OK. Do you think this fix is safe enough to go to the release branch, so as to prevent Emacs 24.4 from crashing in these circumstances?