From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH RFC] GnuTLS: Support TOFU certificate checking. Date: Wed, 08 Oct 2014 15:53:34 +0300 Message-ID: <83eguik9ip.fsf@gnu.org> References: <1412716565-7786-1-git-send-email-toke@toke.dk> <87a957o87z.fsf@alrua-karlstad.karlstad.toke.dk> <87bnpm2249.fsf@toke.dk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1412772841 12899 80.91.229.3 (8 Oct 2014 12:54:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Oct 2014 12:54:01 +0000 (UTC) Cc: tzz@lifelogs.com, toke@toke.dk, emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 08 14:53:53 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XbqkZ-0005up-8K for ged-emacs-devel@m.gmane.org; Wed, 08 Oct 2014 14:53:51 +0200 Original-Received: from localhost ([::1]:36024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbqkY-0000lw-V6 for ged-emacs-devel@m.gmane.org; Wed, 08 Oct 2014 08:53:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XbqkB-0000fZ-5s for emacs-devel@gnu.org; Wed, 08 Oct 2014 08:53:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xbqk6-0001zm-9o for emacs-devel@gnu.org; Wed, 08 Oct 2014 08:53:27 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:47998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xbqk6-0001zb-27 for emacs-devel@gnu.org; Wed, 08 Oct 2014 08:53:22 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0ND400B00LQGVF00@mtaout26.012.net.il> for emacs-devel@gnu.org; Wed, 08 Oct 2014 15:51:32 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0ND4005AQMDW0S90@mtaout26.012.net.il>; Wed, 08 Oct 2014 15:51:32 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175118 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Wed, 08 Oct 2014 14:18:27 +0200 > MailScanner-NULL-Check: 1413375507.63653@xsOGipRhF1W7tfzR6ptQBA > Cc: Ted Zlatanov , emacs-devel@gnu.org >=20 > Toke H=F8iland-J=F8rgensen writes: >=20 > > Right, so (just to make sure I'm understanding you right), what y= ou > > propose is to get rid of all the current validation logic in C (i= .e the > > erroring out) and just return something like ( > hostname> ) -- and then make the lisp code wo= rk out > > the rest? >=20 > Yup, I think that would be more flexible. I don't see how this could be done: the initialization of TLS network stream creates a descriptor and adds it to the descriptors we watch i= n wait_reading_process_output. If that descriptor is invalid, we will likely crash.