all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: vibhavp@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fix browse-url not working when	browse-url-browser-function is a list (regexp . function) pairs
Date: Sat, 25 Apr 2015 19:28:47 +0300	[thread overview]
Message-ID: <83egn8xjcw.fsf@gnu.org> (raw)
In-Reply-To: <87h9s418yi.fsf@gmail.com>

> From: vibhavp@gmail.com
> Date: Sat, 25 Apr 2015 21:44:29 +0530
> 
> Are there any objections to the patch?

But the way browse-url-browser-function is documented, it should be a
list of conses, not a list of lists.  With your change, if
browse-url-browser-function is an alist, like the doc string implies,
the function will now fail.  So other users out there might suffer.

I'd be okay with a backward compatible change that would work with
both forms, but such a change will have to be accompanied by a
suitable change in documentation.

Thanks.




  reply	other threads:[~2015-04-25 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 17:54 [PATCH] Fix browse-url not working when browse-url-browser-function is a list (regexp . function) pairs vibhavp
2015-04-25 16:14 ` vibhavp
2015-04-25 16:28   ` Eli Zaretskii [this message]
2015-04-25 17:10     ` vibhavp
2015-04-25 17:33       ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2015-04-25 17:47 vibhavp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83egn8xjcw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.