From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16737: Question about wait_reading_process_output Date: Mon, 15 Jun 2015 21:04:44 +0300 Message-ID: <83eglconk3.fsf@gnu.org> References: <874mmmbi2p.fsf@linaro.org> <831thdowis.fsf@gnu.org> <87pp4xeym8.fsf@linaro.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1434391589 9563 80.91.229.3 (15 Jun 2015 18:06:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Jun 2015 18:06:29 +0000 (UTC) Cc: 16737@debbugs.gnu.org To: Alex =?UTF-8?Q?Benn=C3=A9e?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 15 20:06:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z4Ylw-0002jv-1u for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jun 2015 20:06:12 +0200 Original-Received: from localhost ([::1]:35867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4Ylv-0000EO-63 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jun 2015 14:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4Yls-0000E6-2X for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 14:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4Ylm-0002LW-Nw for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 14:06:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4Ylm-0002Ku-JX for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 14:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z4Ylm-0002vw-3X for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2015 14:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jun 2015 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16737 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 16737-submit@debbugs.gnu.org id=B16737.143439150911210 (code B ref 16737); Mon, 15 Jun 2015 18:06:01 +0000 Original-Received: (at 16737) by debbugs.gnu.org; 15 Jun 2015 18:05:09 +0000 Original-Received: from localhost ([127.0.0.1]:54935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4Yku-0002uh-0r for submit@debbugs.gnu.org; Mon, 15 Jun 2015 14:05:08 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:59535) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4Ykr-0002u9-Hq for 16737@debbugs.gnu.org; Mon, 15 Jun 2015 14:05:06 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NPZ00500Z8AWY00@mtaout29.012.net.il> for 16737@debbugs.gnu.org; Mon, 15 Jun 2015 21:04:26 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPZ002BOZJE1350@mtaout29.012.net.il>; Mon, 15 Jun 2015 21:04:26 +0300 (IDT) In-reply-to: <87pp4xeym8.fsf@linaro.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103970 Archived-At: > From: Alex Bennée > Cc: Stefan Monnier , 16737@debbugs.gnu.org > Date: Mon, 15 Jun 2015 17:15:59 +0100 > > > The terminal socket reads are run in gobble_input, which is called > > from detect_input_pending (via a few intermediaries). Emacs calls > > detect_input_pending when the pselect call in > > wait_reading_process_output finds that some input has arrived, and > > wait_reading_process_output was called with READ_KBD or WAIT_FOR_CELL > > arguments having values that tell it to do so. > > > > Does this answer your question? > > Sort of. One thing that's confusing is there are two pselect() calls in > the function: > > if ((pselect (max (max_process_desc, max_input_desc) + 1, > &Atemp, > #ifdef NON_BLOCKING_CONNECT > (num_pending_connects > 0 ? &Ctemp : NULL), > #else > NULL, > #endif > NULL, &timeout, NULL) > <= 0)) > > and > > #if defined (HAVE_NS) > nfds = ns_select > #elif defined (HAVE_GLIB) > nfds = xg_select > #else > nfds = pselect > #endif > (max (max_process_desc, max_input_desc) + 1, > &Available, > (check_write ? &Writeok : 0), > NULL, &timeout, NULL); > > Why the two? They watch different (but not orthogonal) sets of channels. > Could there be a case where one is triggering handling so > that the second never gets evaluated? There's no 'continue;' between the 2 calls to 'pselect', so I don't see how this could happen. But it's much easier to put a breakpoint at each call to 'pselect', which just announces itself and continues, or increments some counter, than reason about that humongous loop. Then you'd see very quickly if the scenario that bothers you can actually happen. > Am I right in thinking all incoming X messages (such as those associated > with cut/paste) will come in via the X terminals gobble_input? I think so, but I don't really know, sorry.