From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21028: Performance regression in revision af1a69f4d17a482c359d98c00ef86fac835b5fac (Apr 2014). Date: Fri, 10 Jul 2015 15:41:43 +0300 Message-ID: <83egkgb2wo.fsf@gnu.org> References: <559F9FAF.8090708@live.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1436532148 19700 80.91.229.3 (10 Jul 2015 12:42:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Jul 2015 12:42:28 +0000 (UTC) Cc: 21028@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 10 14:42:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZDXd4-0000Je-AQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jul 2015 14:42:10 +0200 Original-Received: from localhost ([::1]:44528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDXd3-0003Ii-PJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jul 2015 08:42:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDXcz-0003Ic-VL for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 08:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDXcw-0004I4-MJ for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 08:42:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDXcw-0004Hm-Iq for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 08:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZDXcw-0006nj-Be for bug-gnu-emacs@gnu.org; Fri, 10 Jul 2015 08:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jul 2015 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21028 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21028-submit@debbugs.gnu.org id=B21028.143653211426117 (code B ref 21028); Fri, 10 Jul 2015 12:42:02 +0000 Original-Received: (at 21028) by debbugs.gnu.org; 10 Jul 2015 12:41:54 +0000 Original-Received: from localhost ([127.0.0.1]:45955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDXco-0006n9-DX for submit@debbugs.gnu.org; Fri, 10 Jul 2015 08:41:54 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:45992) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDXcl-0006md-FX for 21028@debbugs.gnu.org; Fri, 10 Jul 2015 08:41:52 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NR900200V1CYS00@a-mtaout22.012.net.il> for 21028@debbugs.gnu.org; Fri, 10 Jul 2015 15:41:45 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NR900254V9KQS50@a-mtaout22.012.net.il>; Fri, 10 Jul 2015 15:41:45 +0300 (IDT) In-reply-to: <559F9FAF.8090708@live.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104885 Archived-At: > Date: Fri, 10 Jul 2015 03:34:23 -0700 > From: Clément Pit--Claudel > > I tried to pinpoint the commit that introduced the bug, and found revision af1a69f4d17a482c359d98c00ef86fac835b5fac by bisecting between 24.3 and master. Here's the commit in question: > > af1a69f4d17a482c359d98c00ef86fac835b5fac is the first bad commit > commit af1a69f4d17a482c359d98c00ef86fac835b5fac > Author: Dmitry Antipov > Date: Wed Apr 2 17:24:19 2014 +0400 > > * font.c (font_list_entities): Do not add empty vector to font cache. > (font_matching_entity): Likewise. If matching entity is found, insert > 1-item vector with this entity instead of entity itself (Bug#17125). Maybe I'm blind, but I don't see anything in that changeset that could explain a performance hit. The modified code seems to do approximately the same amount of work, and create the same data structures, as the original one. Are you sure that backing out those changes fixes your problem?