From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/5] Add systemd socket launching support. Date: Sun, 27 Mar 2016 18:23:32 +0300 Message-ID: <83egawymff.fsf@gnu.org> References: <1459027002-13215-1-git-send-email-matthew@mattleach.net> <83mvpkynzd.fsf@gnu.org> <87fuvcosq5.fsf@mattleach.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459092244 17849 80.91.229.3 (27 Mar 2016 15:24:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 15:24:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Matthew Leach Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 27 17:24:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akCXq-00055X-Uq for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 17:24:03 +0200 Original-Received: from localhost ([::1]:36326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCXq-0006az-BC for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 11:24:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCXm-0006aj-FD for emacs-devel@gnu.org; Sun, 27 Mar 2016 11:23:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akCXi-0007Xq-Eo for emacs-devel@gnu.org; Sun, 27 Mar 2016 11:23:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akCXi-0007Xm-BK; Sun, 27 Mar 2016 11:23:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3343 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1akCXh-0000eY-Mg; Sun, 27 Mar 2016 11:23:54 -0400 In-reply-to: <87fuvcosq5.fsf@mattleach.net> (message from Matthew Leach on Sun, 27 Mar 2016 16:17:38 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202294 Archived-At: > From: Matthew Leach > Cc: emacs-devel@gnu.org > Date: Sun, 27 Mar 2016 16:17:38 +0100 > > >> * src/process.c (connect_network_socket): Allow a systemd-allocated > >> file-descriptor to be passed, and use it, avoiding the call to > >> socket() and bind(). > >> (Fmake_network_process): Allow users to pass in :systemd-fd on the > >> parameter plist to use a systemd fd. > >> (wait_reading_process_output): Call socket() & bind() every time. > > > > I'm not sure I understand the rationale for this design. Why do we > > need to drag the systemd socket through all the APIs, including > > exposing its value to Lisp(!), when it is stored in an internal > > variable that can be easily accessed by the low-level network-related > > functions? Why cannot we instead provide a boolean flag that just > > tells these low-level functions to use that socket? > > Indeed, that does seem like a better approach. I'm guessing the flag > you refer to should be passed to make_network_process from server-start? Yes. Thanks.