From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14942: 24.3.50; Improve key descriptions for facemenu menu items Date: Fri, 29 Apr 2016 16:35:18 +0300 Message-ID: <83eg9ownah.fsf@gnu.org> References: <20a01510-8eb7-4920-a7b9-0dcecdd73845@default> <87zisc8sfa.fsf@gnus.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1461937067 21575 80.91.229.3 (29 Apr 2016 13:37:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 13:37:47 +0000 (UTC) Cc: 14942@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 15:37:37 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aw8bw-0004um-NO for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 15:37:36 +0200 Original-Received: from localhost ([::1]:54479 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8bs-00040G-Oy for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 09:37:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8bd-0003eN-Cq for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 09:37:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw8bR-0004fd-OM for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 09:37:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8bR-0004eD-MD for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 09:37:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aw8bO-0003vp-BC for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 09:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14942 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14942-submit@debbugs.gnu.org id=B14942.146193696215022 (code B ref 14942); Fri, 29 Apr 2016 13:37:02 +0000 Original-Received: (at 14942) by debbugs.gnu.org; 29 Apr 2016 13:36:02 +0000 Original-Received: from localhost ([127.0.0.1]:54125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw8aN-0003tu-2V for submit@debbugs.gnu.org; Fri, 29 Apr 2016 09:36:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw8aH-0003td-QA for 14942@debbugs.gnu.org; Fri, 29 Apr 2016 09:35:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw8a2-00044V-3c for 14942@debbugs.gnu.org; Fri, 29 Apr 2016 09:35:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw8a2-00043R-0Y; Fri, 29 Apr 2016 09:35:38 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4597 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aw8Zv-0004wY-S0; Fri, 29 Apr 2016 09:35:32 -0400 In-reply-to: <87zisc8sfa.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 29 Apr 2016 15:18:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117168 Archived-At: > From: Lars Ingebrigtsen > Date: Fri, 29 Apr 2016 15:18:17 +0200 > Cc: 14942@debbugs.gnu.org > > Drew Adams writes: > > > `C-h f facemenu-set-invisible' says that the command is bound to > > v, v. > > [...] > > > This would be a lot more helpful for users if we simply used reasonable > > names for the menu-item pseudo-function keys. Instead of use > > and things suddenly become much clearer. > > What is meant to express, anyway? I thought perhaps it was a > keyboard shortcut, but nothing I press after C-down-mouse-2 seem to do > anything... > > And neither does the v. Use the source, Lars: (defvar facemenu-special-menu (let ((map (make-sparse-keymap "Special"))) (define-key map [?s] (cons (purecopy "Remove Special") 'facemenu-remove-special)) (define-key map [?t] (cons (purecopy "Intangible") 'facemenu-set-intangible)) (define-key map [?v] (cons (purecopy "Invisible") 'facemenu-set-invisible)) (define-key map [?r] (cons (purecopy "Read-Only") 'facemenu-set-read-only)) map) "Menu keymap for non-face text-properties.") (defalias 'facemenu-special-menu facemenu-special-menu) [...] (let ((map facemenu-menu)) (define-key map [in] (cons (purecopy "Indentation") 'facemenu-indentation-menu)) (define-key map [ju] (cons (purecopy "Justification") 'facemenu-justification-menu)) (define-key map [s2] (list (purecopy "--"))) (define-key map [sp] (cons (purecopy "Special Properties") <<<<<<<<< ^^^^ 'facemenu-special-menu)) (define-key map [bg] (cons (purecopy "Background Color") 'facemenu-background-menu)) (define-key map [fg] (cons (purecopy "Foreground Color") 'facemenu-foreground-menu)) (define-key map [fc] (cons (purecopy "Face") 'facemenu-face-menu)))