From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24057: 25.1.50; ffap interprets comments beginning with "//" as file path Date: Tue, 26 Jul 2016 17:41:33 +0300 Message-ID: <83eg6gtqaq.fsf@gnu.org> References: <83lh0sx0yf.fsf@gnu.org> <83shv0v716.fsf@gnu.org> <83poq4v4jk.fsf@gnu.org> <83wpkbt92i.fsf@gnu.org> <83mvl5tzv7.fsf@gnu.org> <83invttyv7.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1469544424 8471 80.91.229.3 (26 Jul 2016 14:47:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jul 2016 14:47:04 +0000 (UTC) Cc: 24057@debbugs.gnu.org, npostavs@users.sourceforge.net To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 26 16:46:53 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bS3dC-00065R-7c for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jul 2016 16:46:50 +0200 Original-Received: from localhost ([::1]:40331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS3dB-0005da-Af for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jul 2016 10:46:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS3Za-0002UU-2o for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2016 10:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS3ZW-00020a-3z for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2016 10:43:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS3ZW-00020W-0F for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2016 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bS3ZV-00079F-Qt for bug-gnu-emacs@gnu.org; Tue, 26 Jul 2016 10:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jul 2016 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24057 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24057-submit@debbugs.gnu.org id=B24057.146954413727409 (code B ref 24057); Tue, 26 Jul 2016 14:43:01 +0000 Original-Received: (at 24057) by debbugs.gnu.org; 26 Jul 2016 14:42:17 +0000 Original-Received: from localhost ([127.0.0.1]:38232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bS3Yj-00077x-13 for submit@debbugs.gnu.org; Tue, 26 Jul 2016 10:42:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bS3Yd-00077d-1m for 24057@debbugs.gnu.org; Tue, 26 Jul 2016 10:42:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS3YT-0001bl-Vi for 24057@debbugs.gnu.org; Tue, 26 Jul 2016 10:42:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS3YI-0001Zn-MN; Tue, 26 Jul 2016 10:41:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1675 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bS3YH-0000qb-0G; Tue, 26 Jul 2016 10:41:45 -0400 In-reply-to: (message from Kaushal Modi on Mon, 25 Jul 2016 20:18:27 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121552 Archived-At: > From: Kaushal Modi > Date: Mon, 25 Jul 2016 20:18:27 +0000 > Cc: 24057@debbugs.gnu.org, npostavs@users.sourceforge.net > > Here a git formatted patch .. it's an optimized, generic version of the > snippet in my previous email. It's now "/" agnostic. Thanks. Most of the patch looks like whitespace changes? > + (setq beg (catch 'break > + (while (< beg-new end) > + (goto-char beg-new) > + (if (nth 4 (syntax-ppss)) ; in a comment > + (throw 'break beg-new) > + (setq beg-new (1+ beg-new)))) > + end)))) ; Set BEG to END if no throw happens Is there any problem with a more conventional while loop that stops when syntax-ppss has its 5th element non-nil? Why did you need to use throw and catch here?