From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 24086@debbugs.gnu.org
Subject: bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame
Date: Wed, 27 Jul 2016 20:06:12 +0300 [thread overview]
Message-ID: <83eg6froxn.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1607272027060.6264@calancha-pc> (message from Tino Calancha on Wed, 27 Jul 2016 20:32:40 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Wed, 27 Jul 2016 20:32:40 +0900 (JST)
>
> When the argument TYPE is 'other-frame, it should visit
> the buffer in a new frame.
Not unconditionally, though. There are clearly some conditions in the
code under which the above should not happen.
> emacs -Q --eval="(progn (require 'ibuffer) (setq ibuffer-expert t) (ibuffer))"
Invoking this command, I get an error:
Wrong type argument: window-live-p, nil
> (defun ibuffer-do-view-1 (type)
> - (let ((marked-bufs (ibuffer-get-marked-buffers)))
> + (let ((marked-bufs (ibuffer-get-marked-buffers))
> + (confirm t))
> (when (null marked-bufs)
> (setq marked-bufs (list (ibuffer-current-buffer t))))
> - (unless (and (eq type 'other-frame)
> + (when (and (eq type 'other-frame)
> (not ibuffer-expert)
> - (> (length marked-bufs) 3)
> - (not (y-or-n-p (format "Really create a new frame for %s
> buffers? "
> - (length marked-bufs)))))
> - (set-buffer-modified-p nil)
> - (delete-other-windows)
> - (switch-to-buffer (pop marked-bufs))
> + (> (length marked-bufs) 3))
> + (setq confirm
> + (y-or-n-p (format "Really create a new frame for %s buffers?
> "
> + (length marked-bufs)))))
> +
> + (when confirm
> + (unless (eq type 'other-frame)
> + (set-buffer-modified-p nil)
> + (delete-other-windows)
> + (switch-to-buffer (pop marked-bufs)))
> (let ((height (/ (1- (if (eq type 'horizontally) (frame-width)
> (frame-height)))
> (1+ (length marked-bufs)))))
Does the change have to be this complicated? AFAICT, the error is
just in the wrong logic of combining the conditions. Right?
Thanks.
next prev parent reply other threads:[~2016-07-27 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 11:32 bug#24086: 25.1.50; ibuffer-do-view-1 fails to visit in new frame Tino Calancha
2016-07-27 17:06 ` Eli Zaretskii [this message]
2016-07-28 13:52 ` Tino Calancha
2016-09-13 15:59 ` Tino Calancha
2016-09-23 6:24 ` Tino Calancha
2016-09-23 6:26 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eg6froxn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24086@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.