From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24206: 25.1; Curly quotes generate invalid strings, leading to a segfault Date: Thu, 18 Aug 2016 21:58:25 +0300 Message-ID: <83eg5lewfi.fsf@gnu.org> References: <8337m7h1dp.fsf@gnu.org> <83zioffew5.fsf@gnu.org> <83popaf1yz.fsf@gnu.org> <87bn0u3rqc.fsf@linux-m68k.org> <83mvkdg91i.fsf@gnu.org> <8b78f23f-4a4f-e568-b760-3350ca7bb8d3@cs.ucla.edu> <83d1l8g3zs.fsf@gnu.org> <4822bfeb-c507-a9ff-93bc-1d27ba93b9d7@cs.ucla.edu> <8360qzfmz3.fsf@gnu.org> <11031c1e-c784-0ba2-4b6c-4fab0cb92354@cs.ucla.edu> <83tweje0ct.fsf@gnu.org> <83lgzudu97.fsf@gnu.org> <7296d150-48aa-0c39-9421-63fffa499d2e@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471546763 8165 195.159.176.226 (18 Aug 2016 18:59:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Aug 2016 18:59:23 +0000 (UTC) Cc: johnw@gnu.org, 24206@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 18 20:59:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baSX7-0001og-6q for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Aug 2016 20:59:17 +0200 Original-Received: from localhost ([::1]:53982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baSX4-0001qg-7t for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Aug 2016 14:59:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baSWy-0001qb-6U for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 14:59:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baSWs-000530-NK for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 14:59:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baSWs-00052v-JS for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 14:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1baSWs-0003Wp-Ba for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Aug 2016 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24206-submit@debbugs.gnu.org id=B24206.147154673013545 (code B ref 24206); Thu, 18 Aug 2016 18:59:02 +0000 Original-Received: (at 24206) by debbugs.gnu.org; 18 Aug 2016 18:58:50 +0000 Original-Received: from localhost ([127.0.0.1]:33624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baSWg-0003WO-7I for submit@debbugs.gnu.org; Thu, 18 Aug 2016 14:58:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baSWe-0003WA-SG for 24206@debbugs.gnu.org; Thu, 18 Aug 2016 14:58:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baSWY-0004wD-QH for 24206@debbugs.gnu.org; Thu, 18 Aug 2016 14:58:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baSWT-0004tj-Ow; Thu, 18 Aug 2016 14:58:37 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3454 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1baSWP-000264-Tm; Thu, 18 Aug 2016 14:58:36 -0400 In-reply-to: <7296d150-48aa-0c39-9421-63fffa499d2e@cs.ucla.edu> (message from Paul Eggert on Thu, 18 Aug 2016 11:33:36 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122375 Archived-At: > Cc: johnw@gnu.org, 24206@debbugs.gnu.org > From: Paul Eggert > Date: Thu, 18 Aug 2016 11:33:36 -0700 > > As I take it, your principal objection to the new code is not to its internals: > it's that substitute-command-keys can now return a multibyte string even when > all the input data is unibyte. I don't think that's a big deal, but if this is > the primary reason for our lengthy conversation, I can move things forward by > changing the code so that it instead returns a unibyte string when all the input > data are unibyte. Would that suffice? No, that's not the primary reason. The primary reason is that I think we should avoid changing code that doesn't necessarily need any changes.