From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24378: [PATCH 1/6] =?UTF-8?Q?Don=E2=80=99t?= use FETCH_MULTIBYTE_CHAR when advancing index Date: Tue, 06 Sep 2016 18:27:31 +0300 Message-ID: <83eg4xaw0s.fsf@gnu.org> References: <1473168498-13194-1-git-send-email-mina86@mina86.com> <1473168694-13605-1-git-send-email-mina86@mina86.com> <83poohay1n.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473175984 30935 195.159.176.226 (6 Sep 2016 15:33:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2016 15:33:04 +0000 (UTC) Cc: 24378@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 17:32:57 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhIMj-0006HX-9x for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 17:32:49 +0200 Original-Received: from localhost ([::1]:34420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIMg-0004FG-02 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 11:32:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIIB-0000L2-Kl for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:28:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhII6-0004PI-My for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:28:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhII6-0004PE-KV for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bhII6-0000Uw-GC for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2016 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24378-submit@debbugs.gnu.org id=B24378.14731756791904 (code B ref 24378); Tue, 06 Sep 2016 15:28:02 +0000 Original-Received: (at 24378) by debbugs.gnu.org; 6 Sep 2016 15:27:59 +0000 Original-Received: from localhost ([127.0.0.1]:51491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhIHz-0000Ua-4Z for submit@debbugs.gnu.org; Tue, 06 Sep 2016 11:27:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhIHt-0000UI-Ub for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 11:27:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhIHn-0004Gv-RC for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 11:27:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIHn-0004Go-Nd; Tue, 06 Sep 2016 11:27:43 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4136 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bhIHm-0007so-87; Tue, 06 Sep 2016 11:27:43 -0400 In-reply-to: (message from Michal Nazarewicz on Tue, 06 Sep 2016 17:17:30 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123011 Archived-At: > From: Michal Nazarewicz > Cc: 24378@debbugs.gnu.org > Date: Tue, 06 Sep 2016 17:17:30 +0200 > > On Tue, Sep 06 2016, Eli Zaretskii wrote: > >> From: Michal Nazarewicz > >> Date: Tue, 6 Sep 2016 15:31:29 +0200 > >> > >> * src/casefiddle.c (casify_region): use STRING_CHAR_AND_LENGTH as a safe > >> alternative to FETCH_MULTIBYTE_CHAR which is documented in src/buffer.h > >> as unsafe when used for advancing index. > > > > AFAIK, that comment is stale and no longer correct. I don't think > > there's a reason to make this change anymore, since STRING_CHAR no > > longer unifies characters. > > I’ll drop the patch in favour of updating the comment in > FETCH_MULTIBYTE_CHAR then. Thanks. While you are at that, please also update a similar comment for STRING_CHAR as well. > /me wonders if STRING_CHAR_AND_LENGTH must be faster than > FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. It might or might not be faster (measurements are welcome), but FETCH_MULTIBYTE_CHAR is safer when the code could GC, because it uses a byte position, not a C pointer to buffer text.