all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 24635@debbugs.gnu.org, qqwy@gmx.com
Subject: bug#24635: 24.5; Missing preview of entered unicode codepoints (C-q codepoint SPC)
Date: Mon, 21 Nov 2016 18:54:12 +0200	[thread overview]
Message-ID: <83eg2493kb.fsf@gnu.org> (raw)
In-Reply-To: <jwvbmx84xcm.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Mon, 21 Nov 2016 11:26:43 -0500)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: qqwy@gmx.com,  24635@debbugs.gnu.org
> Date: Mon, 21 Nov 2016 11:26:43 -0500
> 
> > Stefan, do you see a way to make read-key or the functions it calls
> > echo the input characters?  I didn't see a way to do that, but maybe I
> > missed something.
> 
> Hmm... it would be good to find such a way, indeed, since the issue is
> likely to show at other places where we'd want to use read-key.

Agreed.

> > Failing that, I'm inclined to go back to using read-event in
> > read-quoted-char.  After all, we didn't have any bug reports due to
> > that, and the echo is a valuable feature, IMO.
> 
> Indeed, the scenarios where read-key is preferable to read-event in the
> context of read-quoted-char are fairly hypothetical.
> 
> So, we should probably revert that for now, but adding a comment about
> why we don't use read-key.

OK, will do in a couple of days if no one objects.

The commit I pointed to made 2 more changes in read-quoted-char,
related to the way unread-command-events is set.  I understand that
those two changes also need to be reverted when we go back to using
read-event, right?

Thanks.





  reply	other threads:[~2016-11-21 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  9:53 bug#24635: 24.5; Missing preview of entered unicode codepoints (C-q codepoint SPC) Qqwy/W-M
2016-10-07 12:35 ` Eli Zaretskii
2016-11-21 16:13   ` Eli Zaretskii
2016-11-21 16:26     ` Stefan Monnier
2016-11-21 16:54       ` Eli Zaretskii [this message]
2016-11-25 10:10         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eg2493kb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24635@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=qqwy@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.