From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code Date: Mon, 28 Nov 2016 19:24:44 +0200 Message-ID: <83eg1vzfdv.fsf@gnu.org> References: <87zikk9biz.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480353904 4790 195.159.176.226 (28 Nov 2016 17:25:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2016 17:25:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 28 18:24:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBPfh-0008OY-Fu for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2016 18:24:53 +0100 Original-Received: from localhost ([::1]:60253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBPfl-0004Jg-BW for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2016 12:24:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBPfe-0004JQ-Lg for emacs-devel@gnu.org; Mon, 28 Nov 2016 12:24:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBPfZ-00074p-P6 for emacs-devel@gnu.org; Mon, 28 Nov 2016 12:24:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBPfZ-00074j-Lm; Mon, 28 Nov 2016 12:24:45 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2973 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cBPfY-0007Cr-VH; Mon, 28 Nov 2016 12:24:45 -0500 In-reply-to: <87zikk9biz.fsf@gmail.com> (message from Tino Calancha on Mon, 28 Nov 2016 18:52:36 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209654 Archived-At: > From: Tino Calancha > Date: Mon, 28 Nov 2016 18:52:36 +0900 > Cc: tino.calancha@gmail.com > > how about following patch? > It prevent some duplication of code in subr.el, and it adds > a new test. What about the overhead of a function call? These functions are likely to be invoked in loops. Should we make the common part a defsubst?