From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Date: Tue, 20 Dec 2016 21:37:24 +0200 Message-ID: <83eg122xzf.fsf@gnu.org> References: <831sx36g75.fsf@gnu.org> <837f6u4nmx.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1482262694 11474 195.159.176.226 (20 Dec 2016 19:38:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Dec 2016 19:38:14 +0000 (UTC) Cc: 25230@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 20 20:38:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJQEf-0001XM-O4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Dec 2016 20:38:05 +0100 Original-Received: from localhost ([::1]:53168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJQEk-0007dQ-9k for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Dec 2016 14:38:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJQEf-0007dK-4j for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 14:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJQEc-0007Tq-0x for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 14:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJQEb-0007Te-TQ for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 14:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cJQEb-0002Zp-Lk for bug-gnu-emacs@gnu.org; Tue, 20 Dec 2016 14:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Dec 2016 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25230-submit@debbugs.gnu.org id=B25230.14822626719884 (code B ref 25230); Tue, 20 Dec 2016 19:38:01 +0000 Original-Received: (at 25230) by debbugs.gnu.org; 20 Dec 2016 19:37:51 +0000 Original-Received: from localhost ([127.0.0.1]:49338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJQEP-0002ZL-NJ for submit@debbugs.gnu.org; Tue, 20 Dec 2016 14:37:51 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJQEN-0002Z4-Li for 25230@debbugs.gnu.org; Tue, 20 Dec 2016 14:37:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJQEF-0007Nh-70 for 25230@debbugs.gnu.org; Tue, 20 Dec 2016 14:37:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJQEF-0007Nd-47; Tue, 20 Dec 2016 14:37:39 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3351 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cJQEE-0007FS-1i; Tue, 20 Dec 2016 14:37:38 -0500 In-reply-to: (message from Reuben Thomas on Tue, 20 Dec 2016 18:42:05 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127268 Archived-At: > From: Reuben Thomas > Date: Tue, 20 Dec 2016 18:42:05 +0000 > Cc: 25230@debbugs.gnu.org > > > ​No, because my patch does not change the current behaviour of the code. The assumption that > [:alpha:] is OK to use here instead of A-Za-z is already in the code.​ > > Can you point out where in the code you see that assumption? > > The current code in about line 1300 (ispell-set-spellchecker-params) unconditionally overrides all the built-in > dictionaries' values for casechars and not-casechars with [:alpha:] in the loop that starts > > (dolist (adict ispell-dictionary-alist) …) That's the place where you suggested to keep the original values. I thought there were other places, but it's good to know there are none. > I think so, but we should make sure the hard-wired values work with > Aspell, before we make that change. If they don't, we should provide > something that works for Aspell. > > ​I thought the hard-wired values were only for ispell dictionaries (for aspell, the dictionaries are searched for on > the computer)… But if we find that an installed dictionary is one of those in the data base of the hard-wired values, we use those values, right? Because AFAIK Aspell provides only one of the 3 character sets we need in its dictionaries, the other 2 need to be somehow guessed or provided by the user.