From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests Date: Fri, 10 Feb 2017 10:49:38 +0200 Message-ID: <83efz64ehp.fsf@gnu.org> References: <87inoqqdgr.fsf@calancha-pc> <83d1ex99yh.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486716621 23587 195.159.176.226 (10 Feb 2017 08:50:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Feb 2017 08:50:21 +0000 (UTC) Cc: 25618@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 10 09:50:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc6uD-0005b7-JA for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 09:50:13 +0100 Original-Received: from localhost ([::1]:42536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc6uJ-0002iA-7a for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 03:50:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc6u7-0002bH-4P for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 03:50:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc6u3-00065h-6E for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 03:50:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cc6u3-00065d-2p for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 03:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cc6u2-0001q2-SK for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 03:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2017 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 25618-submit@debbugs.gnu.org id=B25618.14867165837020 (code B ref 25618); Fri, 10 Feb 2017 08:50:02 +0000 Original-Received: (at 25618) by debbugs.gnu.org; 10 Feb 2017 08:49:43 +0000 Original-Received: from localhost ([127.0.0.1]:33786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc6ti-0001pA-K5 for submit@debbugs.gnu.org; Fri, 10 Feb 2017 03:49:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc6tg-0001ow-EO for 25618@debbugs.gnu.org; Fri, 10 Feb 2017 03:49:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc6tX-0005sQ-Cx for 25618@debbugs.gnu.org; Fri, 10 Feb 2017 03:49:35 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc6tX-0005sG-AS; Fri, 10 Feb 2017 03:49:31 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4534 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc6tW-00075v-JW; Fri, 10 Feb 2017 03:49:31 -0500 In-reply-to: (message from Tino Calancha on Sun, 5 Feb 2017 02:54:03 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129188 Archived-At: > From: Tino Calancha > Date: Sun, 5 Feb 2017 02:54:03 +0900 (JST) > cc: Tino Calancha , 25618@debbugs.gnu.org > > On Sat, 4 Feb 2017, Eli Zaretskii wrote: > > >> From: Tino Calancha > >> Date: Sat, 04 Feb 2017 22:42:44 +0900 > >> > >> > >> Prefer set a numeric limit of seconds than using the word 'few'. > >> > >> For instance, in my box the test `cl-seq-test-bug24264' in > >> test/lisp/emacs-lisp/cl-seq-tests.el > >> takes 7 s. > >> With an explicit numeric threshold is easier to decide whether this test > >> must be tagged as expensive or not. > >> > >> In following patch i define a few as 2-3 seconds. Other people might > >> prefer 4-5 or even higher. > >> Please, suggest a proper value to consider a test as expensive. > > > > I think 2-3 sec is negligible, and 7 sec is not long enough to annoy. > > 10 sec or more is beginning to sound like it comes close to "too > > long", and 20 sec is definitely too long. > Thank you. Now is clear. > Are you OK with keep the sentence as it is now? > I mean, keep: 'some few seconds'. It's okay to leave it as is. I also don't object to saying something more specific, but 2-3 sec sound just too few to me.