From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Sun, 07 May 2017 19:53:01 +0300 Message-ID: <83efw0ehhu.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> <87zieo4ov7.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1494176012 20084 195.159.176.226 (7 May 2017 16:53:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 May 2017 16:53:32 +0000 (UTC) Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, tino.calancha@gmail.com, emacs-devel@gnu.org To: Johan =?utf-8?Q?Bockg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 07 18:53:28 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7PR1-00057Y-M9 for ged-emacs-devel@m.gmane.org; Sun, 07 May 2017 18:53:27 +0200 Original-Received: from localhost ([::1]:56189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7PR7-0000Vt-8E for ged-emacs-devel@m.gmane.org; Sun, 07 May 2017 12:53:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7PR1-0000Vo-Jx for emacs-devel@gnu.org; Sun, 07 May 2017 12:53:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7PR0-0005aT-Up for emacs-devel@gnu.org; Sun, 07 May 2017 12:53:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7PQx-0005ZI-BB; Sun, 07 May 2017 12:53:23 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d7PQw-0003sy-5x; Sun, 07 May 2017 12:53:22 -0400 In-reply-to: <87zieo4ov7.fsf@gnu.org> (message from Johan =?utf-8?Q?Bockg?= =?utf-8?Q?=C3=A5rd?= on Sun, 07 May 2017 18:23:56 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214678 Archived-At: > From: Johan Bockgård > Cc: mvoteiza@udel.edu, jean.christophe.helary@gmail.com, emacs-devel@gnu.org, tino.calancha@gmail.com > Date: Sun, 07 May 2017 18:23:56 +0200 > > Eli Zaretskii writes: > > >> >> I think regexp should be surrounded by a grouping construct, like: > >> >> > >> >> (concat "\\`\\(?:" (or regexp "[ \t\n\r]+") "\\)") > >> >> > >> >> And similarly for string-trim-right. > >> > > >> > Rationale? > >> > >> regexp can contain \| > > > > Shouldn't such a regexp be surrounded by "\\(..\\)"? > > This code performs string concatenation on a perfectly valid regexp > provided by the caller. IMO, it is this code's responsibility that the > result is sensible after the concatenation. > > Are you saying this should be the caller's duty? I'm _asking_ whether it should be the caller's duty.