From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#16828: 24.3.50;
	eval-expression, character representation of integer results
	time-consuming
Date: Fri, 19 May 2017 09:34:52 +0300
Message-ID: <83efvl4ann.fsf@gnu.org>
References: <CABr8ebbLKP8As7ud-u3wmJ4cuua1NhKX8_yGpfSd7-1p1ez+bA@mail.gmail.com>
	<83mwhk4v48.fsf@gnu.org>
	<CABr8ebYbBF7AgHHsKWtyAi-c6BHvNpBis48+PgcfcZBH1Y-7OA@mail.gmail.com>
	<83txbr2sye.fsf@gnu.org> <87zjljf086.fsf@rosalinde.fritz.box>
	<83a9di3lt1.fsf@gnu.org> <877g8mb3lh.fsf@Rainer.invalid>
	<b4my510yqdt.fsf@jpl.org> <530DBEEE.8060805@gmx.at>
	<87zig84s6l.fsf@users.sourceforge.net> <83wpbc9ldc.fsf@gnu.org>
	<CAM-tV-_t2bjpE2byh3NvJjw8dfxTwk4rM7EjwSdTM13EgC=-wA@mail.gmail.com>
	<83lgrs9k8p.fsf@gnu.org> <87inmw3x5b.fsf@users.sourceforge.net>
	<83fui09i5z.fsf@gnu.org> <87fui03pjr.fsf@users.sourceforge.net>
	<834lyg9b9t.fsf@gnu.org> <87a88752ej.fsf@users.sourceforge.net>
	<83y3vr9909.fsf@gnu.org> <878tltiure.fsf@users.sourceforge.net>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1495175775 7772 195.159.176.226 (19 May 2017 06:36:15 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 19 May 2017 06:36:15 +0000 (UTC)
Cc: 16828@debbugs.gnu.org
To: npostavs@users.sourceforge.net
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 19 08:36:11 2017
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1dBbWD-0001pg-Dt
	for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 May 2017 08:36:09 +0200
Original-Received: from localhost ([::1]:56805 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1dBbWI-00054C-Re
	for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 May 2017 02:36:14 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34813)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBbWB-00052W-7A
	for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 02:36:08 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBbW6-0001uR-90
	for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 02:36:07 -0400
Original-Received: from debbugs.gnu.org ([208.118.235.43]:51566)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dBbW6-0001uM-6G
	for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 02:36:02 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBbW6-0005OK-04
	for bug-gnu-emacs@gnu.org; Fri, 19 May 2017 02:36:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Fri, 19 May 2017 06:36:01 +0000
Resent-Message-ID: <handler.16828.B16828.149517571120662@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 16828
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
Original-Received: via spool by 16828-submit@debbugs.gnu.org id=B16828.149517571120662
	(code B ref 16828); Fri, 19 May 2017 06:36:01 +0000
Original-Received: (at 16828) by debbugs.gnu.org; 19 May 2017 06:35:11 +0000
Original-Received: from localhost ([127.0.0.1]:54243 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1dBbVG-0005NB-PU
	for submit@debbugs.gnu.org; Fri, 19 May 2017 02:35:11 -0400
Original-Received: from eggs.gnu.org ([208.118.235.92]:43629)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <eliz@gnu.org>) id 1dBbVF-0005My-FK
	for 16828@debbugs.gnu.org; Fri, 19 May 2017 02:35:09 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1dBbV5-0001de-DG
	for 16828@debbugs.gnu.org; Fri, 19 May 2017 02:35:04 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38898)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1dBbV5-0001da-A0; Fri, 19 May 2017 02:34:59 -0400
Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3187
	helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1dBbV4-0001ah-Em; Fri, 19 May 2017 02:34:58 -0400
In-reply-to: <878tltiure.fsf@users.sourceforge.net>
	(npostavs@users.sourceforge.net)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 208.118.235.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
	the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs/>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
	<bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:132622
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/132622>

> From: npostavs@users.sourceforge.net
> Cc: 16828@debbugs.gnu.org
> Date: Thu, 18 May 2017 19:56:53 -0400
> 
> >> Currently, zero also means no truncation, keeping that meaning seems
> >> important too.  Perhaps a negative argument would be a better choice?
> >
> > Yes, that'd be fine with me.  Thanks.
> 
> I added `-' to echo in character format, and `-1' to print it to the
> buffer.  I split the patch in 2 parts, the first just refactors the
> printing code, the 2nd adds the new behaviour.

Thanks.

A couple of nits regarding the documentation part:

> +(defcustom eval-expression-print-maximum-character 127
> +  "The largest integer that will be displayed as a character.
> +This affects printing by `eval-expression-print-format'."

I would suggest to also mention eval-expression here.

> --- a/doc/emacs/building.texi
> +++ b/doc/emacs/building.texi
> @@ -1485,7 +1485,8 @@ Lisp Eval
>  Emacs Lisp expression preceding point in the buffer, and displays the
>  value in the echo area.  When the result of an evaluation is an
>  integer, it is displayed together with the value in other formats
> -(octal, hexadecimal, and character).
> +(octal, hexadecimal, and character if
> +@code{eval-expression-print-maximum-character} allows it).

Please add a "see below" here, as the description of the variable is
several dozens of lines farther.

> +@code{eval-expression-print-maximum-character} prevents large integers
> +from being displayed as characters.

This is too terse, IMO; please state explicitly that values larger
than this will not be displayed as characters.