From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 16828@debbugs.gnu.org
Subject: bug#16828: 24.3.50; eval-expression, character representation of integer results time-consuming
Date: Fri, 19 May 2017 09:34:52 +0300 [thread overview]
Message-ID: <83efvl4ann.fsf@gnu.org> (raw)
In-Reply-To: <878tltiure.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)
> From: npostavs@users.sourceforge.net
> Cc: 16828@debbugs.gnu.org
> Date: Thu, 18 May 2017 19:56:53 -0400
>
> >> Currently, zero also means no truncation, keeping that meaning seems
> >> important too. Perhaps a negative argument would be a better choice?
> >
> > Yes, that'd be fine with me. Thanks.
>
> I added `-' to echo in character format, and `-1' to print it to the
> buffer. I split the patch in 2 parts, the first just refactors the
> printing code, the 2nd adds the new behaviour.
Thanks.
A couple of nits regarding the documentation part:
> +(defcustom eval-expression-print-maximum-character 127
> + "The largest integer that will be displayed as a character.
> +This affects printing by `eval-expression-print-format'."
I would suggest to also mention eval-expression here.
> --- a/doc/emacs/building.texi
> +++ b/doc/emacs/building.texi
> @@ -1485,7 +1485,8 @@ Lisp Eval
> Emacs Lisp expression preceding point in the buffer, and displays the
> value in the echo area. When the result of an evaluation is an
> integer, it is displayed together with the value in other formats
> -(octal, hexadecimal, and character).
> +(octal, hexadecimal, and character if
> +@code{eval-expression-print-maximum-character} allows it).
Please add a "see below" here, as the description of the variable is
several dozens of lines farther.
> +@code{eval-expression-print-maximum-character} prevents large integers
> +from being displayed as characters.
This is too terse, IMO; please state explicitly that values larger
than this will not be displayed as characters.
next prev parent reply other threads:[~2017-05-19 6:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 10:01 bug#16828: 24.3.50; eval-expression, character representation of integer results time-consuming Anders Lindgren
2014-02-21 10:29 ` Eli Zaretskii
2014-02-22 12:49 ` Anders Lindgren
2014-02-22 13:11 ` Eli Zaretskii
2014-02-22 18:53 ` Stephen Berman
2014-02-22 21:00 ` Eli Zaretskii
2014-02-23 9:06 ` Achim Gratz
2014-02-25 0:42 ` Katsumi Yamaoka
2014-02-26 10:16 ` martin rudalics
2017-03-26 3:45 ` npostavs
2017-03-26 14:13 ` Eli Zaretskii
2017-03-26 14:19 ` Noam Postavsky
2017-03-26 14:37 ` Eli Zaretskii
2017-03-26 14:55 ` npostavs
2017-03-26 15:22 ` Eli Zaretskii
2017-03-26 17:39 ` npostavs
2017-03-26 17:51 ` Eli Zaretskii
2017-03-26 18:16 ` npostavs
2017-03-26 18:40 ` Eli Zaretskii
2017-05-18 23:56 ` npostavs
2017-05-19 6:34 ` Eli Zaretskii [this message]
2017-05-19 20:52 ` npostavs
2017-05-19 21:09 ` Eli Zaretskii
2017-05-19 22:28 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83efvl4ann.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16828@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.