From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28505: 26.0.60; Crash in Fmove_point_visually Date: Tue, 19 Sep 2017 20:13:15 +0300 Message-ID: <83efr2has4.fsf@gnu.org> References: <877ewvixax.fsf@blei.turtle-trading.net> <87d16n7maz.fsf@blei.turtle-trading.net> <83shfjgwf8.fsf@gnu.org> <87ingefyzy.fsf@blei.turtle-trading.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505843272 6026 195.159.176.226 (19 Sep 2017 17:47:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 17:47:52 +0000 (UTC) Cc: 28505@debbugs.gnu.org To: Benjamin Riefenstahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 19 19:47:47 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duMcd-0001Kr-Oc for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Sep 2017 19:47:47 +0200 Original-Received: from localhost ([::1]:44453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duMcl-0003L7-5J for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Sep 2017 13:47:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duM63-0007Ko-Bh for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 13:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duM5z-0000lN-GE for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 13:14:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duM5z-0000l6-Ck for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 13:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1duM5x-0007f0-Qg for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2017 13:14:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Sep 2017 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28505 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28505-submit@debbugs.gnu.org id=B28505.150584122129413 (code B ref 28505); Tue, 19 Sep 2017 17:14:01 +0000 Original-Received: (at 28505) by debbugs.gnu.org; 19 Sep 2017 17:13:41 +0000 Original-Received: from localhost ([127.0.0.1]:48522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duM5d-0007eL-0S for submit@debbugs.gnu.org; Tue, 19 Sep 2017 13:13:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duM5b-0007e8-K5 for 28505@debbugs.gnu.org; Tue, 19 Sep 2017 13:13:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duM5S-00007O-Nl for 28505@debbugs.gnu.org; Tue, 19 Sep 2017 13:13:34 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duM5S-000077-L5; Tue, 19 Sep 2017 13:13:30 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1819 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1duM5R-00059B-K4; Tue, 19 Sep 2017 13:13:30 -0400 In-reply-to: <87ingefyzy.fsf@blei.turtle-trading.net> (message from Benjamin Riefenstahl on Tue, 19 Sep 2017 18:13:05 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137138 Archived-At: > From: Benjamin Riefenstahl > Cc: 28505@debbugs.gnu.org > Date: Tue, 19 Sep 2017 18:13:05 +0200 > > > if (row < MATRIX_FIRST_TEXT_ROW (w->current_matrix) > > || row > MATRIX_BOTTOM_TEXT_ROW (w->current_matrix, w)) > > goto simulate_display; > > MATRIX_BOTTON_TEXT_ROW calculates "rows + nrows" (plus the mode-line, > but this is the minibuffer, so it does not have a mode-line). So > despite the name of the macro the result points *after* the bottom row, > not *at* it. Should that comparison be "row >= BOTTOM"? I'll try that. > The macro seems to be misnamed though if that is the problem. Ah, yes. MATRIX_BOTTON_TEXT_ROW gives the last row + 1, so this was an off-by-one error. Should be fixed now.