From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24710: 26.0.50; Feature request: Replace double quotes in electric-quote-mode Date: Fri, 29 Sep 2017 10:08:42 +0300 Message-ID: <83efqq9e2t.fsf@gnu.org> References: <4fc323e0-ed0a-cc36-08df-d337200d1549@cs.ucla.edu> <83h8vsajyg.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506669022 32057 195.159.176.226 (29 Sep 2017 07:10:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 29 Sep 2017 07:10:22 +0000 (UTC) Cc: 24710@debbugs.gnu.org, eggert@cs.ucla.edu To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 29 09:10:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxpR7-0007ft-LB for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 09:10:13 +0200 Original-Received: from localhost ([::1]:33954 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxpRF-0001b1-1O for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 03:10:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxpR2-0001Wc-Ad for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:10:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxpQw-0006fi-TQ for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:10:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxpQw-0006f9-PO for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxpQw-0004to-GH for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2017 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24710-submit@debbugs.gnu.org id=B24710.150666894218742 (code B ref 24710); Fri, 29 Sep 2017 07:10:02 +0000 Original-Received: (at 24710) by debbugs.gnu.org; 29 Sep 2017 07:09:02 +0000 Original-Received: from localhost ([127.0.0.1]:37469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxpPx-0004sA-TR for submit@debbugs.gnu.org; Fri, 29 Sep 2017 03:09:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxpPw-0004ru-1Y for 24710@debbugs.gnu.org; Fri, 29 Sep 2017 03:09:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxpPn-0005QU-Fs for 24710@debbugs.gnu.org; Fri, 29 Sep 2017 03:08:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxpPn-0005QM-CR; Fri, 29 Sep 2017 03:08:51 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4909 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dxpPm-0000WD-Qx; Fri, 29 Sep 2017 03:08:51 -0400 In-reply-to: (message from Philipp Stephani on Sun, 24 Sep 2017 07:04:07 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137558 Archived-At: > From: Philipp Stephani > Date: Sun, 24 Sep 2017 07:04:07 +0000 > Cc: 24710@debbugs.gnu.org > > Eli Zaretskii wrote: > > Thanks. How about updating the Emacs manual as well? > > Yes, other than that it looks good to me. > > OK, here's a new patch. Thanks, this LGTM. > Subject: [PATCH] Electric quote mode: Conditionally replace " (Bug#24710) > > * lisp/electric.el (electric-quote-replace-double): New user option. > (electric-quote-post-self-insert-function): Use it. > > * electric-tests.el (electric-quote-replace-double-disabled) > (electric-quote-replace-double-bob) > (electric-quote-replace-double-bol) > (electric-quote-replace-double-after-space) > (electric-quote-replace-double-after-letter) > (electric-quote-replace-double-after-paren): New unit tests. Please add the log entries for the documentation here, when you push.