From: Eli Zaretskii <eliz@gnu.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: emacs-devel@gnu.org
Subject: Re: Adding new variable for face-list in internal-make-lisp-face.
Date: Sat, 04 Nov 2017 20:16:52 +0200 [thread overview]
Message-ID: <83efpducx7.fsf@gnu.org> (raw)
In-Reply-To: <m2mv42q6mu.wl%esq@lawlist.com> (message from Keith David Bershatsky on Sat, 04 Nov 2017 10:46:17 -0700)
> Date: Sat, 04 Nov 2017 10:46:17 -0700
> From: Keith David Bershatsky <esq@lawlist.com>
> Cc: emacs-devel@gnu.org
>
> I ran into one little `emacs_abort` snag this morning while trying the following two test snippets, which came about when I changed the face background with `face-remap-add-relative` on a face that had been previously defined with `defface`.
>
> Should I run a pre-test for all 15 cases in lookup_basic_face to see if it would throw an `emacs_abort`, and then *only* call lookup_basic_face if success is guaranteed?
>
> Alternatively, perhaps using it.face_id obviates the need to use lookup_basic_face?
>
> TEST SNIPPETS:
>
> struct face *tab_face = FACE_FROM_ID (f, lookup_basic_face (f, it.face_id));
> Lisp_Object tab_bg = tab_face->lface[LFACE_BACKGROUND_INDEX];
> AUTO_STRING (my_string_one, "IT background: %s");
> CALLN (Fmessage, my_string_one, tab_bg);
You only need to call lookup_basic_face if it.face_id is a basic face
AND face-remapping-alist is non-nil. If it.face_id is not a basic
face, lookup_basic_face will abort, and you should call lookup_face
instead. For a remapped non-basic face you will have to look up
face-remapping-alist manually and then use lookup_named_face.
next prev parent reply other threads:[~2017-11-04 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 17:46 Adding new variable for face-list in internal-make-lisp-face Keith David Bershatsky
2017-11-04 18:16 ` Eli Zaretskii [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-04 6:56 Keith David Bershatsky
2017-11-04 8:13 ` Eli Zaretskii
2017-11-03 22:01 Keith David Bershatsky
2017-11-04 8:05 ` Eli Zaretskii
2017-11-03 3:50 Keith David Bershatsky
2017-11-03 10:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83efpducx7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.